Skip to content

Use docker image tags to control versioning - #8103

Merged
phelpsdb merged 2 commits into
mainfrom
phelpsdb-docker-tag-versioning
Apr 15, 2024
Merged

Use docker image tags to control versioning#8103
phelpsdb merged 2 commits into
mainfrom
phelpsdb-docker-tag-versioning

Conversation

@phelpsdb

@phelpsdbphelpsdb commented Apr 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Use docker image tags to set versions, step 1 of phasing out audius-docker-compose and the current release process that involves merging git branches.

How Has This Been Tested?

Ran docker tagging shell script through shellcheck.
Will observe CI.

@changeset-bot

changeset-botBot commented Apr 13, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c81d5f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@phelpsdb
phelpsdbforce-pushed the phelpsdb-docker-tag-versioning branch from d847fef to 1c367e5CompareApril 13, 2024 02:13
@phelpsdb
phelpsdbforce-pushed the phelpsdb-docker-tag-versioning branch from 1c367e5 to c403b6cCompareApril 13, 2024 02:18
@audius-infra

audius-infra commented Apr 13, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/phelpsdb-docker-tag-versioning

@phelpsdb
phelpsdb marked this pull request as ready for review April 15, 2024 08:32
@phelpsdb
phelpsdb requested a review from theoilieApril 15, 2024 08:32
theoilie
theoilie approved these changes Apr 15, 2024
View reviewed changes

@theoilietheoilie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! if any of this might break prod you could always test the circleci local dryrun command

Comment thread.circleci/src/commands/@docker-commands.yml
@audius-infra

audius-infra commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/phelpsdb-docker-tag-versioning

@phelpsdb
phelpsdb merged commit 7c7b226 into mainApr 15, 2024
@phelpsdb
phelpsdb deleted the phelpsdb-docker-tag-versioning branch April 15, 2024 19:35
schottra added a commit that referenced this pull request Apr 15, 2024
@schottra
Merge remote-tracking branch 'origin/main' into rs-manager-mode-poc
4af8c26
* origin/main: (167 commits)
Use docker image tags to control versioning (#8103)
[C-3949] Fix infinite library bug (#8107)
ACDC tip notifs: encode hash id (#8101)
[PAY-2597] Test migration of a single endpoint from apiclient -> SDK (#8091)
Fix preview start and end point parsing (#8106)
[PROTO-1515] Hide modification buttons for ddex tracks and albums (#8097)
Bump version to 0.6.81
v1.5.76
[PAY-2689] Send tips via SDK (behind feature flag) (#8090)
require handle_lc in users query (#8102)
[PAY-2687] E2E tests for premium album edits (#8082)
Fix missing isTrack dependency (lint change) (#8096)
ddex: limit publisher to 3 retries (#8062)
Bump version to 0.6.80
remove unused import (#8098)
[C-4268] Fix player sagas prev functionality for premium track previews (#8094)
Disable play e2e test (#8095)
[PAY-2652] Album purchase/sale notifications (#8085)
[DVRL-25] - Using Wallet Connect on the Protocol Dashboard (#8089)
[C-4252] Update search screen navigation to clear search on mobile (#8092)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@theoilietheoilietheoilie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phelpsdb@audius-infra@theoilie