Skip to content

Add redirect path and fix #/? issue in scratch - #8245

Merged
stereosteve merged 1 commit into
ddex-single-procfrom
rj-proto-1783-scratch
Apr 26, 2024
Merged

Add redirect path and fix #/? issue in scratch#8245
stereosteve merged 1 commit into
ddex-single-procfrom
rj-proto-1783-scratch

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Description

See sister PR:

And also, for details on the redirect_mode
https://stackoverflow.com/questions/14707345/oauth2-query-string-vs-fragment

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

See other PR

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bfa381e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@cloudflare/workers-types@3.16.0None065 kBthreepointone
npm/@tanstack/react-query@4.10.3Transitive: environment+13.33 MBtannerlinsley
npm/@types/react-dom@18.0.6None028 kBtypes
npm/@types/react@18.0.21None+31.38 MBtypes
npm/@vitejs/plugin-react@4.0.4Transitive: environment, filesystem, unsafe+5711 MBvitebot
npm/ethers@6.8.1network Transitive: environment, filesystem+1020.1 MBricmoo
npm/hashids@2.2.10None0133 kBniieani
npm/postcss@8.4.30environment, filesystem+3372 kBai
npm/react-dom@18.2.0environment+34.62 MBgnoff
npm/react-router-dom@6.4.2environment Transitive: network+22.02 MBmjackson
npm/react@18.2.0environment+2337 kBgnoff
npm/regenerator-runtime@0.14.0None027.8 kBbenjamn
npm/typescript@4.8.4None068.8 MBtypescript-bot

🚮 Removed packages:npm/@amplitude/node@1.9.2, npm/@amplitude/react-native@2.17.2, npm/@apollo/client@3.3.7, npm/@babel/cli@7.7.0, npm/@babel/plugin-proposal-class-static-block@7.21.0, npm/@babel/plugin-transform-react-jsx@7.21.0, npm/@babel/plugin-transform-runtime@7.18.2, npm/@babel/preset-env@7.22.15, npm/@babel/preset-typescript@7.22.15, npm/@babel/register@7.7.0, npm/@changesets/cli@2.27.1, npm/@cloudflare/kv-asset-handler@0.3.1, npm/@coinbase/cbpay-js@1.2.0, npm/@coinflowlabs/react-native@2.1.5, npm/@coinflowlabs/react@3.1.5, npm/@coral-xyz/anchor@0.29.0, npm/@elastic/elasticsearch@8.1.0, npm/@emotion/babel-preset-css-prop@11.11.0, npm/@emotion/css@11.11.2, npm/@emotion/eslint-plugin@11.11.0, npm/@emotion/native@11.11.0, npm/@emotion/react@11.11.1, npm/@emotion/server@11.11.0, npm/@emotion/styled@11.11.0, npm/@esbuild-plugins/node-globals-polyfill@0.2.3, npm/@escape.tech/mookme@2.4.1, npm/@fingerprintjs/fingerprintjs-pro@3.5.6, npm/@google/model-viewer@3.3.0, npm/@gorhom/portal@1.0.9, npm/@hcaptcha/react-hcaptcha@0.3.6, npm/@juggle/resize-observer@3.3.1, npm/@jup-ag/api@6.0.6

View full report↗︎

@socket-security

Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

AlertPackageNoteSource
Protestware/Troll package npm/es5-ext@0.10.62
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
  • orphan: npm/es5-ext@0.10.62
Install scripts npm/es5-ext@0.10.62
  • Install script:postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0
  • orphan: npm/es5-ext@0.10.62
Install scripts npm/esbuild@0.18.20
  • orphan: npm/esbuild@0.18.20
Critical CVE npm/protobufjs@6.11.3
  • orphan: npm/protobufjs@6.11.3
Install scripts npm/protobufjs@6.11.3
  • Install script:postinstall
  • Source:node scripts/postinstall
  • orphan: npm/protobufjs@6.11.3
Install scripts npm/bigint-buffer@1.1.5
  • Install script:install
  • Source:npm run rebuild || echo "Couldn't build bindings. Non-native version used."
  • orphan: npm/bigint-buffer@1.1.5
Critical CVE npm/@babel/traverse@7.22.20

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/es5-ext@0.10.62
  • @SocketSecurity ignore npm/esbuild@0.18.20
  • @SocketSecurity ignore npm/protobufjs@6.11.3
  • @SocketSecurity ignore npm/bigint-buffer@1.1.5
  • @SocketSecurity ignore npm/@babel/traverse@7.22.20

@stereostevestereosteve left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@stereosteve
stereosteve merged commit 97b477d into ddex-single-procApr 26, 2024
@stereosteve
stereosteve deleted the rj-proto-1783-scratch branch April 26, 2024 14:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@raymondjacobson@stereosteve