Skip to content

[PAY-2881] Fix access & sale showing hidden by default#8352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DejayJD merged 4 commits into from
May 6, 2024
Merged

[PAY-2881] Fix access & sale showing hidden by default #8352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3454fd
Fix access & sale showing hidden by default
DejayJD May 6, 2024
5aacc33
fix unit test
DejayJD May 6, 2024
a07a0dd
Merge branch 'main' of github.com:AudiusProject/audius-protocol into …
DejayJD May 6, 2024
827d501
Add is private to metadata schema
DejayJD May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/common/src/hooks/useAccessAndRemixSettings.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,7 +328,7 @@ describe('useAccessAndRemixSettings', () => {
disableSpecialAccessGateFields: true,
disableCollectibleGate: true,
disableCollectibleGateFields: true,
disableHidden: false
disableHidden: true
}
expect(actual).toEqual(expected)
})
Expand DownExpand Up@@ -393,7 +393,7 @@ describe('useAccessAndRemixSettings', () => {
disableSpecialAccessGateFields: true,
disableCollectibleGate: true,
disableCollectibleGateFields: true,
disableHidden: false
disableHidden: true
}
expect(actual).toEqual(expected)
})
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/hooks/useAccessAndRemixSettings.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,7 @@ export const useAccessAndRemixSettings = ({
disableCollectibleGate || (!isUpload && !isInitiallyHidden)

const disableHidden =
isScheduledRelease || (!isUpload && !isInitiallyUnlisted)
isAlbum || isScheduledRelease || (!isUpload && !isInitiallyUnlisted)

return {
disableUsdcGate,
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/schemas/metadata.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ export const newTrackMetadata = (fields, validate = false): TrackMetadata => {
const collectionMetadataSchema = {
is_album: false,
is_current: true,
is_private: true,

@DejayJDDejayJDMay 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully confident in the implications here. I'm assuming this was set to true by default as a precaution, but it seems incorrect since the user should set it via the modal

@dharit-tandharit-tanMay 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont have context on this either, can someone from client chime in?

@amendelsohnamendelsohnMay 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need true here because when you click the create playlist or create album button in the app, we want it to create as hidden by default for you to add tracks and publish later.

I think we should leave this set to true and override it in the upload/edit submit based on the form values

@DejayJDDejayJDMay 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm yeah that makes sense. I'll rework this

@DejayJDDejayJDMay 6, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought about this some more and I started to see if I could just keep it false by default and make sure the album/playlist buttons were setting it to true.
Turns out I didn't even need to do anything, it's already explicitly being set.
https://github.com/AudiusProject/audius-protocol/blob/jd/access-and-sale-hidden-disable/packages/web/src/common/store/cache/collections/createPlaylistSaga.ts#L114

@amendelsohnamendelsohnMay 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that works for me 👍

is_private: false,
tags: null,
genre: null,
mood: null,
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/schemas/upload/uploadFormSchema.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -269,6 +269,7 @@ export const createCollectionSchema = (collectionType: 'playlist' | 'album') =>
}),
is_unlisted: z.optional(z.boolean()),
is_album: z.literal(collectionType === 'album'),
is_private: z.optional(z.boolean()),
tracks: z.array(z.object({ metadata: CollectionTrackMetadataSchema })),
ddex_release_ids: z.optional(z.record(z.string()).nullable()),
artists: z.optional(z.array(DDEXResourceContributor).nullable()),
Expand Down