Skip to content

[PAY-3071][PAY-3072] Fix track listing in manager mode - #8704

Merged
schottra merged 1 commit into
mainfrom
rs-fix-hidden-tracks-mgr-mode
Jun 4, 2024
Merged

[PAY-3071][PAY-3072] Fix track listing in manager mode#8704
schottra merged 1 commit into
mainfrom
rs-fix-hidden-tracks-mgr-mode

Conversation

@schottra

@schottraschottra commented Jun 4, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This updates the get_tracks query to include unlisted tracks when current_user_id == user_id and the current authenticated user is either the owner or an active manager of the owner.

fixes PAY-3071
fixes PAY-3072

How Has This Been Tested?

Updated integration tests to verify correct behavior.

@changeset-bot

changeset-botBot commented Jun 4, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3cc0a2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schottra
schottra commented Jun 4, 2024
View reviewed changes
Comment threadpackages/discovery-provider/integration_tests/queries/test_get_tracks.py
db = get_db()

populate_tracks(db)
populate_tracks(db)

@schottraschottraJun 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why these tests mostly run outside the app context. But the check for managed users throws if we're not inside one.

@raymondjacobsonraymondjacobsonJun 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python weird

@schottraschottraJun 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think python would say JS weird.

raymondjacobson
raymondjacobson approved these changes Jun 4, 2024
View reviewed changes

@raymondjacobsonraymondjacobson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment threadpackages/discovery-provider/integration_tests/queries/test_get_tracks.py
db = get_db()

populate_tracks(db)
populate_tracks(db)

@raymondjacobsonraymondjacobsonJun 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python weird

@schottra
schottra merged commit 3f133aa into mainJun 4, 2024
@schottra
schottra deleted the rs-fix-hidden-tracks-mgr-mode branch June 4, 2024 19:39
audius-infra pushed a commit that referenced this pull request Jun 5, 2024
audius-infra
Audius Protocol v0.6.119
7425e7f
[1a300f1] [PAY-3083] Add user socials in DN (#8706) Saliou Diallo
[44aa909] correct default discovery listens behavior (#8724) alecsavvy
[6d9eda8] Pin turbo in docker files (#8713) Sebastian Klingler
[da787c5] Hotfix: Fix non-purchase access gates (#8711) Marcus Pasell
[3f133aa] [PAY-3071][PAY-3072] Fix track listing in manager mode (#8704) Randy Schott
[de22da7] ONC: add check for old uploads (#8689) alecsavvy
[3ef78ea] [PAY-3070][PAY-3075] Fix a few endpoints incorrectly using current user id (#8687) Randy Schott
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
@rickyromborickyromboAwaiting requested review from rickyrombo

Assignees

@dharit-tandharit-tan

@nicoback2nicoback2

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schottra@raymondjacobson@dharit-tan@nicoback2