Skip to content

[C-4465] Update usdc transactional emails - #8744

Merged
isaacsolo merged 6 commits into
mainfrom
is-transactional-fund-email
Jun 11, 2024
Merged

[C-4465] Update usdc transactional emails#8744
isaacsolo merged 6 commits into
mainfrom
is-transactional-fund-email

Conversation

@isaacsolo

Copy link
Copy Markdown

Description

Update these e-mails for the new design system.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Ran notifications plugin locally and sent e-mails to myself.

@changeset-bot

changeset-botBot commented Jun 6, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 072ffd0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@isaacsolo
isaacsolo requested a review from DejayJDJune 6, 2024 18:10
@isaacsoloisaacsolo changed the title Update usdc transactional emails[C-4465] Update usdc transactional emailsJun 6, 2024
@gitguardian

gitguardianBot commented Jun 7, 2024

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 16 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian idGitGuardian statusSecretCommitFilename
11648675TriggeredGeneric High Entropy Secret72e7810.envView secret
11648676TriggeredGeneric High Entropy Secret72e7810.envView secret
11648677TriggeredGeneric High Entropy Secret72e7810.envView secret
11648678TriggeredGeneric High Entropy Secret72e7810.envView secret
10116465TriggeredGeneric High Entropy Secret72e7810.envView secret
11648679TriggeredGeneric High Entropy Secret72e7810.envView secret
11648680TriggeredGeneric High Entropy Secret72e7810.envView secret
11648681TriggeredGeneric High Entropy Secret72e7810.envView secret
10116465TriggeredGeneric High Entropy Secrete2afc3f.envView secret
11648675TriggeredGeneric High Entropy Secrete2afc3f.envView secret
11648676TriggeredGeneric High Entropy Secrete2afc3f.envView secret
11648677TriggeredGeneric High Entropy Secrete2afc3f.envView secret
11648678TriggeredGeneric High Entropy Secrete2afc3f.envView secret
11648679TriggeredGeneric High Entropy Secrete2afc3f.envView secret
11648680TriggeredGeneric High Entropy Secrete2afc3f.envView secret
11648681TriggeredGeneric High Entropy Secrete2afc3f.envView secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment on lines +114 to +121
.mobile {
display: block !important;
width: auto !important;
height: auto !important;
float: none !important;
}
.email-container {
width: 100% !important;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats a lot of !important lol

name: string
handle: string
is_deactivated: boolean
profile_picture_sizes: string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a string? I thought this was an object of some sort

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one note about types tho

@isaacsolo
isaacsolo enabled auto-merge (squash) June 11, 2024 18:01
@isaacsolo
isaacsolo merged commit c44bfdc into mainJun 11, 2024
@isaacsolo
isaacsolo deleted the is-transactional-fund-email branch June 11, 2024 18:07
audius-infra pushed a commit that referenced this pull request Jun 12, 2024
[05c268e] add key + bpm fields to discovery track metadata (#8757) Michelle Brier
[66aa450] add listens rate limiter with tests (#8786) alecsavvy
[32ffd84] add new graph urls (#8795) alecsavvy
[d9b4ee3] Add release_date, is_scheduled_release to playlist api (#8790) Reed
[667037e] [PAY-2849] Support gated content in Manager Mode (#8746) Randy Schott
[c44bfdc] [C-4465] Update usdc transactional emails (#8744) Isaac Solo
[fbe5cbe] Add vendor to buyer notification (#8787) Isaac Solo
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacsolo@DejayJD