Hash migration by stereosteve · Pull Request #8852 · AudiusProject/apps

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve · 2024-06-17T19:56:58Z

Description

Second commit contains the meat of PR.

During migration:

Drop Replica Count from 5 to 4
Rendezvous order will take top 2 from legacy crc32 ordering... rest will be from sha256 ordering.
Skip rehashing blob content to verify cid during migration period (to make it go faster).
Increase delete threshold from R+1 to R+2. Since we are dropping R by 1, this should be fine.

After migration is complete (e.g. repair tracker reporting low numbers of blobs moving)... make these changes:

Return to R=5
Remove the hybrid ordering... just call rank for sha256 ordering.
Un-skip rehashing blob content.

In most cases I added HashMigration comment for things to undo

changeset-bot · 2024-06-17T19:57:02Z

⚠️ No Changeset found

Latest commit: 1f77d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michellebrier

nice

michellebrier · 2024-06-17T21:20:56Z

 }
 	}

-	// replicate under-replicated blobs:


why remove this?

In practice it causes nodes to spam each other too much in prod...
Ideally repair.go should only make network requests to actually get a file.
I commented this out a while ago and it's just been sitting here commented out for a while.

raymondjacobson

lgtm

raymondjacobson · 2024-06-17T22:05:37Z

-	hashRing := rendezvous.New(hosts...)
-	orderedHosts := hashRing.GetN(len(hosts), key)
+func NewRendezvousHasher(hosts []string) *RendezvousHasher {
+	deadHosts := "https://content.grassfed.network/"


raymondjacobson · 2024-06-17T22:07:54Z

- // }
- // }
-
+	if !isPlaced && !ss.Config.StoreAll && tracker.CleanupMode && alreadyHave && myRank > ss.Config.ReplicationFactor+2 && !wasReplicatedThisWeek {


when we go live, what is ReplicationFactor set to? 4?

[bd8e475] Hash migration (#8852) Steve Perkins [80e048f] fix cid colname (#8859) Michelle Brier [b236298] fix gorm automigrate typo (#8857) Michelle Brier [ca2060c] Mediorum audio analysis for Qm cids (#8847) Michelle Brier [458e94a] Make content node metric recording non-blocking (#8854) JD Francis [723b3fb] Fix album search (#8851) Sebastian Klingler [74270c0] fix essentia pkg config on stage/prod nodes (#8849) Michelle Brier

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

stereosteve added 3 commits June 17, 2024 15:23

delete old code in repair.go
f8be77d

Hash migraiton: use R2(crc32) + R2(sha256) during migration.
4baa090

Test for hash migration
eb4eff2

pull-request-sizeBot added the size/L label Jun 17, 2024

stereosteve requested review from michellebrier and raymondjacobson June 17, 2024 19:57

fix tests
1f77d4f

michellebrier approved these changes Jun 17, 2024
View reviewed changes

michellebrier reviewed Jun 17, 2024
View reviewed changes

raymondjacobson approved these changes Jun 17, 2024
View reviewed changes

stereosteve merged commit bd8e475 into mainJun 18, 2024

stereosteve deleted the hash-migration branch June 18, 2024 03:03

This was referenced Jun 18, 2024
Python impl of sha256 + hybrid rendezvous ordering #8866
Merged
typescript impl of R2(crc32) + R2(sha256) ordering. #8942
Merged

Uh oh!

Conversation

stereosteve commented Jun 17, 2024

Description

Uh oh!

changeset-botBot commented Jun 17, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

michellebrier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raymondjacobson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stereosteve commented Jun 17, 2024

Description

Uh oh!

changeset-botBot commented Jun 17, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

michellebrier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raymondjacobson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stereosteve commented Jun 17, 2024

Description

Uh oh!

changeset-botBot commented Jun 17, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

michellebrier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raymondjacobson left a comment

Choose a reason for hiding this comment

changeset-botBot commented Jun 17, 2024•
edited
Loading

changeset-botBot commented Jun 17, 2024•
edited
Loading

changeset-botBot commented Jun 17, 2024•
edited
Loading

changeset-botBot commented Jun 17, 2024•
edited
Loading