') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [PAY-3160] Try other tables for txhash if users table doesn't work. by stereosteve · Pull Request #9123 · AudiusProject/apps · GitHub
Skip to content

[PAY-3160] Try other tables for txhash if users table doesn't work. - #9123

Merged
stereosteve merged 1 commit into
mainfrom
fix-pubkey-recover
Jul 15, 2024
Merged

[PAY-3160] Try other tables for txhash if users table doesn't work.#9123
stereosteve merged 1 commit into
mainfrom
fix-pubkey-recover

Conversation

@stereosteve

@stereostevestereosteve commented Jul 15, 2024

Copy link
Copy Markdown
Contributor

Description

Initially was thinking we could query eth directly, but since there is still a relay step, the outer tx is not actually signed by user's wallet.

So try other tables to find a txhash that is signed by user.

How Has This Been Tested?

Deployed to sandbox, modified users txhash + cleared cache + tested with affected user's pubkey.

@changeset-bot

changeset-botBot commented Jul 15, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 42705d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dharit-tan
dharit-tan reviewed Jul 15, 2024
View reviewed changes
Comment threadcomms/discovery/pubkeystore/recover.go

}

rows.Close()

@dharit-tandharit-tanJul 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the "try POA" steps above?

@stereostevestereosteveJul 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess POA is a lost cause at this point. Doing that will let us consolidate the two steps.

@stereostevestereosteveJul 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this now and come back to do that cleanup

@stereosteve
stereosteve merged commit 435611f into mainJul 15, 2024
@stereosteve
stereosteve deleted the fix-pubkey-recover branch July 15, 2024 20:05
audius-infra pushed a commit that referenced this pull request Jul 16, 2024
audius-infra
Audius Protocol v0.6.148
d24d690
[ee1d388] drop old audio analyses ops (#9132) Michelle Brier
[1e43cd2] fix log error in analysis repairer (#9133) Michelle Brier
[03eb95d] Fix MRI clm / udr s3 configs (#9128) Steve Perkins
[15289b2] img cache: check for empty bytes and add skipCache query param (#9129) Steve Perkins
[2de07fc] clean up key/bpm repairer (#9077) Michelle Brier
[435611f] [PAY-3160] Try other tables for txhash if users table doesn't work. (#9123) Steve Perkins
[b1d6e1b] Python impl of sha256 + hybrid rendezvous ordering (#8866) Steve Perkins
[93d4c1b] Update es-indexer readme, fix tests. (#9022) Steve Perkins
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
+1 more reviewer
@dharit-tandharit-tandharit-tan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stereosteve@raymondjacobson@dharit-tan