Uh oh!
There was an error while loading. Please reload this page.
Specifiers should be strings in challenge notifs - #9148
Conversation
|
isaacsolo
left a comment
There was a problem hiding this comment.
ah thanks yea sometimes the specifier is a string and sometimes it's an int. confusing because we encode as an int elsewhere when it can only be an int for the notificaiton type.
[ffd2ad3] [PAY-2783] Add filters to manager endpoints (#9109) Randy Schott [dc387b0] [PAY-3166] Updates ESLint dependencies to fix broken IDE experience (#9146) Randy Schott [bda6e63] Specifiers should be strings in challenge notifs (#9148) Raymond Jacobson [96efa17] Cycle solana RPC connections better (#9147) Raymond Jacobson [3d5ff3a] [C-4777] Prevent public track with future release date (#9139) Reed [faf7908] Final touches to UDR (#9144) Raymond Jacobson [15b031c] PROTO-1781: move verified notifs into pedalboard + ci (#9130) alecsavvy [8d442d3] Fix misc UDR bugs (#9141) Raymond Jacobson [1183296] PROTO-1879: rm PUT /user/email route (#9089) alecsavvy
Description
The specifier looks like "1=>2" and can't be int-encoded.
Currently my notifs on stage won't load. Seems like we handle this as a string client side anyway https://github.com/AudiusProject/audius-protocol/blob/165a890c8e9ecfcfcb6367d9d5edb741da09abd4/packages/discovery-provider/plugins/notifications/src/types/notifications.ts#L131
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.