Skip to content

Remove use_sdk_tips feature flag (and fix indexing check) - #9193

Merged
rickyrombo merged 1 commit into
mainfrom
mjp-sdk-tips-ff
Jul 22, 2024
Merged

Remove use_sdk_tips feature flag (and fix indexing check)#9193
rickyrombo merged 1 commit into
mainfrom
mjp-sdk-tips-ff

Conversation

@rickyrombo

@rickyromborickyrombo commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

Description

Removes the feature flag for using SDK to send tips. Also fixes the polling to check for a tip to be indexed to not throw errors and actually check that the tip was indexed not if the supporter was present.

How Has This Been Tested?

Tested locally against stage by sending a tip.

@changeset-bot

changeset-botBot commented Jul 19, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4fc8332

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra

audius-infra commented Jul 19, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/mjp-sdk-tips-ff

raymondjacobson
raymondjacobson approved these changes Jul 19, 2024
View reviewed changes

@raymondjacobsonraymondjacobson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

dharit-tan
dharit-tan reviewed Jul 21, 2024
View reviewed changes
Comment threadpackages/web/src/common/store/tipping/sagas.ts
dharit-tan
dharit-tan reviewed Jul 21, 2024
View reviewed changes
Comment threadpackages/web/src/common/store/tipping/sagas.ts
dharit-tan
dharit-tan approved these changes Jul 21, 2024
View reviewed changes

@dharit-tandharit-tan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay delete all the codez

@rickyrombo
rickyrombo merged commit e45bdae into mainJul 22, 2024
@rickyrombo
rickyrombo deleted the mjp-sdk-tips-ff branch July 22, 2024 23:55
schottra added a commit that referenced this pull request Jul 23, 2024
@schottra
Merge remote-tracking branch 'origin/main' into update-dn-models
7dc2377
* origin/main:
Audius Protocol v0.6.153
mutex around crc32 hasher (#9231)
Improve logging spam situation (#9238)
[C-4792] Disallow Add To Playlist for hidden tracks (#9236)
[PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234)
Remove use_sdk_purchase_track and use_sdk_purchase_album feature flags (#9192)
Add ability to change playlist/track visibility w/ audius-cmd (#9094)
Remove use_sdk_tips feature flag (and fix indexing check) (#9193)
Pin docker-compose-plugin to fix env var issue (#9235)
[QA-1449] [C-4808] Reassign playlist_contents in get_bulk_playlists (#9232)
[C-4832] Fix missing play counts on track tiles (#9230)
[QA-1442] Add offline indicator to collection card (#9227)
[QA-1463] Change order of mobile action buttons (#9229)
audius-infra pushed a commit that referenced this pull request Jul 27, 2024
audius-infra
Audius Client (Web and Mobile) v1.5.92
66a3f00
[bea9c85] Fix previously scheduled edit flow (#9278) Dylan Jeffers
[9468507] Improve mobile inner-form revert (#9277) Dylan Jeffers
[15ce2a7] [C-3251] Fix initial state for hidden price-audience field (#9276) Dylan Jeffers
[51a67b4] Fix runtime issue with advanced field (#9275) Dylan Jeffers
[09acfe3] [PAY-3265, PAY-3241] Disallow scheduled playlists in upload/edit; Fix mood placeholder (#9272) Andrew Mendelsohn
[65c886a] [C-4690] Wire up advanced search deep links (#9271) Sebastian Klingler
[deebd52] [C-4874] Update time to 11:59 when scheduling for same day (#9266) Andrew Mendelsohn
[cc407c6] Fix missing refactor bug (#9270) Saliou Diallo
[42e8d11] [PAY-3232] Fix hidden visibility bug when setting price and audience fields (#9268) Saliou Diallo
[523c341] Revert "Update models used in DN reposts endpoints" (#9269) Randy Schott
[89d1e76] [C-4840] Update search screen to auto focus the input (#9263) Kyle Shanks
[9e72dba] [C-4867] Fix collection release date timezone (#9267) Dylan Jeffers
[f5abafe] [C-4866] Fix edit collection form submit (#9262) Dylan Jeffers
[a834436] [PAY-3187] Fix messed up back button form state for payment settings (#9260) Raymond Jacobson
[c3c5b45] [PAY-3196][PAY-3230] Fix miscellaneous editable access issues on mobile (#9258) Saliou Diallo
[823bc63] [C-4793, C-4791] Don't favorite hidden album tracks on purchase (#9254) Andrew Mendelsohn
[6055711] [C-4863] Fix cascading publish on edit collection (#9249) Andrew Mendelsohn
[7500e91] [C-4634] Add popularity sort to users and collections (#9250) Dylan Jeffers
[cd24c79] [C-4843] [C-4846] More advanced search UI fixes (#9252) Sebastian Klingler
[d05de85] [C-4865] Make metadata links visible (#9248) Sebastian Klingler
[8ebbb9d] [C-4847] Reset search filters scroll position (#9242) Sebastian Klingler
[d43760d] PAY-3186 Fixes issue preventing edit screen from opening twice (#9247) Marcus Pasell
[7ffc65c] [C-4834] Animate clear search button for search v2 (#9246) Sebastian Klingler
[24ed1c6] [C-4860] Add waitlist hint for premium album (#9243) Dylan Jeffers
[b336657] Fix type error from SDK update (#9245) Randy Schott
[4fb3d7d] Fix same day scheduled release on web (#9240) Dylan Jeffers
[305a9ef] [PAY-3190] Improve profile page pull to refresh (#9241) Raymond Jacobson
[73a7131] [C-4841] Fix search v2 navigation on mobile (#9233) Sebastian Klingler
[df91fca] [C-4853] Mobile Edit Collection (#9237) Dylan Jeffers
[6473ab1] Update models used in DN reposts endpoints (#9228) Randy Schott
[2c09b40] [C-4792] Disallow Add To Playlist for hidden tracks (#9236) Andrew Mendelsohn
[11f5325] [PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234) Saliou Diallo
[f495382] Remove use_sdk_purchase_track and use_sdk_purchase_album feature flags (#9192) Marcus Pasell
[e45bdae] Remove use_sdk_tips feature flag (and fix indexing check) (#9193) Marcus Pasell
[8174034] [C-4832] Fix missing play counts on track tiles (#9230) Kyle Shanks
[20e739c] [QA-1442] Add offline indicator to collection card (#9227) Dylan Jeffers
[fc3648e] [QA-1463] Change order of mobile action buttons (#9229) Reed
[b7ea2fc] [C-4837] Fix links for the searching by electronic subgenre from track page (#9225) Kyle Shanks
[3bd33d4] [QA-1452] Fix edit playlist issues (#9226) Dylan Jeffers
[cedf459] [C-4848] Remove search v2 responsiveness and fix padding on mobile web (#9224) Sebastian Klingler
[e60706c] [C-4842] Fix tag press on mobile for search v2 (#9223) Kyle Shanks
[9e455f2] [C-4829] Fix mobile web drawer overflow (#9220) Dylan Jeffers
[e0af62a] [QA-1458] Fix artwork image loading (#9219) Dylan Jeffers
[4355378] Update dapp-store build artifacts audius-infra
[1aa1dd2] [QA-1455] Fix disappearing playlists in sidebar (#9216) Dylan Jeffers
[9a7ddbf] [C-4643] Feature flag scheduled premium album release (#9215) Dylan Jeffers
[dff2b2d] Bump mobile versions to 107 (#9218) Dylan Jeffers
[42611cb] [PAY-3177][PAY-3185] Fix mobile track publish button (#9213) Saliou Diallo
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes
+3 more reviewers
@schottraschottraschottra approved these changes
@dharit-tandharit-tandharit-tan approved these changes
@sddiouldesddiouldesddioulde approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rickyrombo@audius-infra@schottra@raymondjacobson@dharit-tan@sddioulde