Skip to content

[PAY-3201] Fix chat blast reactions - #9487

Merged
dharit-tan merged 1 commit into
mainfrom
rt-reactions
Aug 19, 2024
Merged

[PAY-3201] Fix chat blast reactions#9487
dharit-tan merged 1 commit into
mainfrom
rt-reactions

Conversation

@dharit-tan

@dharit-tandharit-tan commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

Description

Forgot to join on chat_blast in this one place.

How Has This Been Tested?

Screenshot 2024-08-19 at 4 44 30 PM

@changeset-bot

changeset-botBot commented Aug 19, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8aff171

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rickyrombo
rickyrombo approved these changes Aug 19, 2024
View reviewed changes
Comment threadcomms/discovery/db/queries/get_chat_messages.go
// Get a chat message
const chatMessage = `
select message_id, chat_id, user_id, created_at, ciphertext from chat_message where chat_id = $1 and message_id = $2
SELECT chat_message.message_id, chat_message.chat_id, chat_message.user_id, chat_message.created_at,

@rickyromborickyromboAug 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need is_plaintext or anything?

@dharit-tandharit-tanAug 19, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict this is only used in validateChatReact in validator.go so i don't think so

@dharit-tan
dharit-tan enabled auto-merge (squash) August 19, 2024 21:23
@dharit-tan
dharit-tan disabled auto-merge August 19, 2024 22:54
@dharit-tan
dharit-tan merged commit b53b774 into mainAug 19, 2024
@dharit-tan
dharit-tan deleted the rt-reactions branch August 19, 2024 23:01
audius-infra pushed a commit that referenced this pull request Aug 20, 2024
audius-infra
Audius Protocol v0.6.172
c6059fa
[b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott
[b53b774] [PAY-3201] Fix chat blast reactions (#9487) Reed
[bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo
[5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed
[d4de8a1] [PAY-3299] Chat blast sender endpoints (#9473) Steve Perkins
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyromborickyromborickyrombo approved these changes
@stereostevestereosteveAwaiting requested review from stereosteve
@amendelsohnamendelsohnAwaiting requested review from amendelsohn

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dharit-tan@rickyrombo