Skip to content

[PAY-3375] get chat endpoint correctly filters for audience:type:id - #9545

Merged
stereosteve merged 1 commit into
mainfrom
get-chat-audience-filter
Aug 26, 2024
Merged

[PAY-3375] get chat endpoint correctly filters for audience:type:id#9545
stereosteve merged 1 commit into
mainfrom
get-chat-audience-filter

Conversation

@stereosteve

@stereostevestereosteve commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Description

Get chat endpoint works correctly for blast audience like: customer_audience:track:1

@changeset-bot

changeset-botBot commented Aug 26, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2e939ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stereostevestereosteve changed the title get chat endpoint correctly filters for audience:type:id[PAY-3375] get chat endpoint correctly filters for audience:type:idAug 26, 2024
dharit-tan
dharit-tan reviewed Aug 26, 2024
View reviewed changes
Comment threadcomms/discovery/rpcz/chat_blast_test.go

ctx := context.Background()
tx := db.Conn.MustBegin()
defer tx.Rollback()

@dharit-tandharit-tanAug 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for?

@stereostevestereosteveAug 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If assertion fails tx is held open and has to timeout... so this makes sure it closes straight away. Just makes it faster to re-run tests after a failure.

@stereosteve
stereosteve merged commit 6b170d0 into mainAug 26, 2024
@stereosteve
stereosteve deleted the get-chat-audience-filter branch August 26, 2024 19:35
audius-infra pushed a commit that referenced this pull request Aug 27, 2024
audius-infra
Audius Protocol v0.6.177
1ff4bfd
[eed6296] Fix include_network_cut parameter (#9555) Marcus Pasell
[48b8641] Fix purchasers endpoint (#9549) Andrew Mendelsohn
[53deb4b] Remove marshalling for nft-gated-signatures (#9550) Randy Schott
[6b170d0] [PAY-3375] get chat endpoint correctly filters for audience:type:id (#9545) Steve Perkins
[84f4781] [PAY-3380] Skip geo indexing on local dev stack (#9544) Reed
[ba1aaed] Fix trending reward notifs (#9532) Isaac Solo
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dharit-tandharit-tandharit-tan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stereosteve@dharit-tan