Skip to content

[C-4968] Sort pinned comments to top - #9677

Merged
dylanjeffers merged 1 commit into
mainfrom
c-4968-pin-sort
Sep 16, 2024
Merged

[C-4968] Sort pinned comments to top#9677
dylanjeffers merged 1 commit into
mainfrom
c-4968-pin-sort

Conversation

@dylanjeffers

@dylanjeffersdylanjeffers commented Sep 8, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Ensures pinned comments are sorted to the top of the sort list.
Adds test

Note, his includes all the sort changes, which have yet to be reviewed in another pr

@changeset-bot

changeset-botBot commented Sep 8, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 622b534

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra

audius-infra commented Sep 8, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/c-4968-pin-sort

@dylanjeffers
dylanjeffers requested review from a team and DejayJD and removed request for a teamSeptember 9, 2024 15:23
@dylanjeffersdylanjeffers changed the title [C-4968] Sort pinned comments to top[C-4968, C-4943] Sort pinned comments to topSep 16, 2024
DejayJD
DejayJD reviewed Sep 16, 2024
View reviewed changes
Comment threadpackages/discovery-provider/src/queries/get_comments.py
Comment.is_delete == False,
)
.order_by(asc(Comment.created_at))
.order_by(desc(Comment.is_pinned), sort_method_order_by)

@DejayJDDejayJDSep 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is the only change over the other PR?

DejayJD
DejayJD approved these changes Sep 16, 2024
View reviewed changes

@DejayJDDejayJD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me (after the other PR goes in)

@dylanjeffersdylanjeffers changed the title [C-4968, C-4943] Sort pinned comments to top[C-4968] Sort pinned comments to topSep 16, 2024
@dylanjeffers
dylanjeffers merged commit ebd220b into mainSep 16, 2024
@dylanjeffers
dylanjeffers deleted the c-4968-pin-sort branch September 16, 2024 19:56
audius-infra pushed a commit that referenced this pull request Sep 17, 2024
audius-infra
Audius Protocol v0.6.192
c25bcb1
[d7c8a4c] [C-4973] Add edit comment e2e (#9679) Dylan Jeffers
[99fb10f] [C-4971] Add comment pin e2e (#9678) Dylan Jeffers
[ebd220b] [C-4968] Sort pinned comments to top (#9677) Dylan Jeffers
[66b1b2c] [C-4943] Add comment sort (#9672) Dylan Jeffers
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@DejayJDDejayJDDejayJD approved these changes
@sliptypesliptypesliptype approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dylanjeffers@audius-infra@DejayJD@sliptype