Uh oh!
There was an error while loading. Please reload this page.
[C-5033] Prevent notification when artist comments - #9799
Merged
Conversation
|
dylanjeffers
enabled auto-merge (squash)
September 19, 2024 22:49
| begin | ||
| if new.is_delete is false then | ||
| if new.user_id != owner_user_id then |
There was a problem hiding this comment.
in this case new.is_delete isn't necessary because there's on conflict do nothing but other cases it's actually important to avoid things like double counting
isaacsolo
approved these changes
Sep 20, 2024
schottra added a commit
that referenced
this pull request
Sep 23, 2024
* origin/main: (161 commits) Audius Client (Web and Mobile) v1.5.100 Add client support for single transaction reward claiming (#9801) Enable audiusd workflow in main release (#9820) Version Packages (#9772) Add audius-d to monorepo (#9808) push cmds for core (#9807) Reapply libs split (#9817) [C-5026] Optimistic UI tweaks (web only for now) (#9816) Reactions also unset is_hidden for blast sender (#9813) Don't show empty chat prompt for blasts (#9815) [QA-1732] Undo test code to fix unread pill check for notifications (#9814) [PAY-3214] Add CreateBlast CTA to followers and supporters user lists (web) (#9804) [PAY-3426] Set unread count when seeding chats with blasts (#9812) [C-5033] Prevent notification when artist comments (#9799) Add back /d route, aka /uptime (#9809) UDF for chat_allowed (#9789) Audius Protocol v0.6.195 revert max width on chats (#9806) [PAY-3216] Update upload share buttons (#9805) Revert libs split (#9802) ...
audius-infra pushed a commit
that referenced
this pull request
Sep 23, 2024
[1e9eb11] worker to fix truncated qm audio cids (#9810) Steve Perkins [e28b82b] Add client support for single transaction reward claiming (#9801) Marcus Pasell [b0252db] Add audius-d to monorepo (#9808) Danny [1c2edae] Reapply libs split (#9817) Sebastian Klingler [6455bae] Reactions also unset is_hidden for blast sender (#9813) Reed [07c0e5a] [PAY-3426] Set unread count when seeding chats with blasts (#9812) Reed [075ea1a] [C-5033] Prevent notification when artist comments (#9799) Dylan Jeffers [d2b6cb4] Add back /d route, aka /uptime (#9809) endline [3f862a8] UDF for chat_allowed (#9789) Steve Perkins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents issue where an artist commenting on their own track would send them a comment notification.
Also removes
new.is_deletecondition as that is uncessary.