') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [PAY-3463] Chat is_hidden respects cleared_history_at by dharit-tan · Pull Request #9919 · AudiusProject/apps · GitHub
Skip to content

[PAY-3463] Chat is_hidden respects cleared_history_at - #9919

Merged
dharit-tan merged 1 commit into
mainfrom
rt-cleared-history
Oct 2, 2024
Merged

[PAY-3463] Chat is_hidden respects cleared_history_at#9919
dharit-tan merged 1 commit into
mainfrom
rt-cleared-history

Conversation

@dharit-tan

@dharit-tandharit-tan commented Oct 1, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Take cleared_history_at into account in chatUpdateLatestFields when deciding whether to set chat_member.is_hidden to false.
Only set is_hidden to false if there exist messages or reactions that were sent aftercleared_history_at.

How Has This Been Tested?

Tested on local stack:

  • artist deleting convo indeed hides convo, even after sending more blasts
  • fan reacting/responding still unhides chat for artist
  • fan reacting to older messages than artist's cleared_history_at - chat remains hidden for artist
  • fan clearing history - only shows blasts after cleared_history_at

Note: I tested one case that still is a bit off:
fan clears history, artist sends blast: chat is still hidden on fan side. Then artist sends another blast, now chat is unhidden for fan. Not entirely sure why this is, but i think this is good enough for now - 2nd blast or message from artist will come thru, and if fan refreshes they will see the chat.

@changeset-bot

changeset-botBot commented Oct 1, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 42702ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dharit-tan
dharit-tan merged commit 0ee4515 into mainOct 2, 2024
@dharit-tan
dharit-tan deleted the rt-cleared-history branch October 2, 2024 17:13
schottra added a commit that referenced this pull request Oct 2, 2024
@schottra
Merge remote-tracking branch 'origin/main' intopay-3388-implement-cl…
11be754
…ient-v1-feed
* origin/main: (316 commits)
[QA-1749] Fix help alignment (#9923)
Re-enable payment router tests after network cut (#9926)
[PAY-3199] Inbox Settings UI (mobile) (#9922)
Add distro sources (#9908)
[PAY-3463] Chat is_hidden respects cleared_history_at (#9919)
Only send blast notifs when no existing chat (#9916)
[C-5002] Empty comments state for track owner (#9928)
[C-5057] Make comment overflow actions consistent with designs (#9920)
[PAY-3477] Initialize Hedgehog directly in client (#9909)
Move debug to externals (#9917)
Audius Protocol v0.7.3
Upgrade mobile apps to 116 (#9927)
Notify Slack on new purchases (#9921)
entity manager in core (#9910)
[PAY-3329] Remove monetization beta waitlist (#9913)
[QA-1724] Fix broken insta links (#9911)
Use mediorum/mediorum_pkg/.version.json while pkg re-org in flight (#9918)
Unblock CI (#9915)
Fix get playlist API playlist contents (#9912)
Migrate to new user/tracks/remixed endpoint (#9900)
...
audius-infra pushed a commit that referenced this pull request Oct 3, 2024
audius-infra
Audius Protocol v0.7.4
f700638
[2999fcc] Re-enable payment router tests after network cut (#9926) Marcus Pasell
[39c02a4] Add distro sources (#9908) Steve Perkins
[0ee4515] [PAY-3463] Chat is_hidden respects cleared_history_at (#9919) Reed
[f807632] Only send blast notifs when no existing chat (#9916) Reed
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
@dharit-tan@samgutentag
[PAY-3463] Chat is_hidden respects cleared_history_at (#9919)
3c8e163
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
audius-infra@samgutentag
Audius Protocol v0.7.4
e59be58
[2999fcc] Re-enable payment router tests after network cut (#9926) Marcus Pasell
[39c02a4] Add distro sources (#9908) Steve Perkins
[0ee4515] [PAY-3463] Chat is_hidden respects cleared_history_at (#9919) Reed
[f807632] Only send blast notifs when no existing chat (#9916) Reed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyromborickyromborickyrombo approved these changes
+1 more reviewer
@stereostevestereostevestereosteve approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dharit-tan@stereosteve@rickyrombo