Move mediorum into top level audius-protocol go module by endline · Pull Request #9938 · AudiusProject/apps

endline · 2024-10-02T20:50:15Z

mediorum is now a top level pkg and is instantiated by the cmd/mediorum target.
also reduces resulting docker image size by 75%

mediorum edge 83f76c98f1ad 24 hours ago 2GB
mediorum latest f2d7285061b9 22 seconds ago 542MB

TEST

# native build
go build -o bin/mediorum cmd/mediorum/main.go
# local dev
make mediorum-dev
# test dev & ci tooling
audius-compose test mediorum
audius-compose build mediorum
audius-compose build --prod mediorum
# test bpm and key analysis
docker run --rm -ti -v ./file_example_WAV_10MG.wav:/wav/example.wav --entrypoint /bin/bash audius-protocol-mediorum -c "analyze-key /wav/example.wav"
G minor
docker run --rm -ti -v ./file_example_WAV_10MG.wav:/wav/example.wav --entrypoint /bin/bash audius-protocol-mediorum -c "analyze-bpm /wav/example.wav"
BPM: 120.904
Confidence: 3.02578

changeset-bot · 2024-10-02T20:50:19Z

⚠️ No Changeset found

Latest commit: 403a444

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2024-10-02T20:50:20Z

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11648675	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/run.go	View secret
11648675	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/mediorum.go	View secret
11648678	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/mediorum.go	View secret
11648678	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/run.go	View secret
11648679	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/mediorum.go	View secret
11648679	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/run.go	View secret
11648680	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/run.go	View secret
11648680	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/mediorum.go	View secret
11648681	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/mediorum.go	View secret
11648681	Triggered	Generic High Entropy Secret	`d40d74f`	pkg/mediorum/run.go	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-10-02T21:03:25Z

Preview this change https://demo.audius.co/endl/pkg-mediorum

audius-infra · 2024-10-02T21:59:36Z

Preview this change https://demo.audius.co/endl/pkg-mediorum

audius-infra · 2024-10-02T22:26:12Z

Preview this change https://demo.audius.co/endl/pkg-mediorum

audius-infra · 2024-10-02T22:46:47Z

Preview this change https://demo.audius.co/endl/pkg-mediorum

alecsavvy

epic

audius-infra · 2024-10-03T16:37:39Z

Preview this change https://demo.audius.co/endl/pkg-mediorum

audius-infra · 2024-10-03T21:27:35Z

Preview this change https://demo.audius.co/endl/pkg-mediorum

phelpsdb · 2024-10-03T21:39:38Z

is this file supposed to be here?

endline · 2024-10-03T21:52:56Z

adding last makefile changes

satisfied with PASS here

audius-infra · 2024-10-04T15:02:58Z

Preview this change https://demo.audius.co/endl/pkg-mediorum

docker build -f ./cmd/mediorum/Dockerfile .

[9d45442] [C-5046, C-5047] Add comment notification settings (#9882) Dylan Jeffers [85ff920] Batch chat blast notifications by blastId and userId (#9949) Reed [c30c411] Move mediorum into top level audius-protocol go module (#9938) endline

…ient-v1-feed * origin/main: (22 commits) Audius Protocol v0.7.6 [C-5046, C-5047] Add comment notification settings (#9882) [PROTO-1944] Dynamically resize Qm image variants (#9960) Fix mobile lint (#9968) Upgrade mobile apps to 117 (#9967) Audius Client (Web and Mobile) v1.5.102 Move core into top level audius-protocol go module (#9940) Fix bottom sheet keyboard avoiding + compose ui (#9964) [C-5097] Add backspace handling back to mobile ComposerInput (#9962) [C-4994] Add user autocomplete and tagging to mobile ComposerInput (#9952) Slim image missing ca-certs (#9961) Batch chat blast notifications by blastId and userId (#9949) [QA-1748] Fix misc sign up issues (#9957) Move mediorum into top level audius-protocol go module (#9938) core: cleanup sandboxes (#9946) Audius Protocol v0.7.5 [PAY-3493] Fix download gating on usdc feature flag (#9945) [C-5025] Add compose ui helper text (#9955) [C-5082] Comments desktop replies tweaks (#9954) [C-5068] Convert comments a-query to tanstack-query (#9944) ...

Co-authored-by: endline <endline>

[9d45442] [C-5046, C-5047] Add comment notification settings (#9882) Dylan Jeffers [85ff920] Batch chat blast notifications by blastId and userId (#9949) Reed [c30c411] Move mediorum into top level audius-protocol go module (#9938) endline

pull-request-sizeBot added the size/XXL label Oct 2, 2024

endline requested review from alecsavvy and phelpsdb October 2, 2024 22:26

endline force-pushed the endl/pkg-mediorum branch from 885528d to 54291dbCompare October 2, 2024 22:33

alecsavvy approved these changes Oct 3, 2024
View reviewed changes

endline force-pushed the endl/pkg-mediorum branch from a8493ba to 9d4427bCompare October 3, 2024 16:26

endline force-pushed the endl/pkg-mediorum branch 3 times, most recently from 1178208 to 8daff90Compare October 3, 2024 21:14

phelpsdb approved these changes Oct 3, 2024
View reviewed changes

endline added 10 commits October 4, 2024 09:25

Mv mediorum .go files to pkg/mediorum
8923a58

Update mediorum imports
5a62925

Update mediorum version.json path
24752fe

Mv mediorum to top level go.mod and tidy
49da4a7

Mv ./mediorum to ./cmd/mediorum
d40d74f

Build mediorum Dockerfile from new structure
08350f6
docker build -f ./cmd/mediorum/Dockerfile .

Make audius-compose build mediorum work
52656ef

Add make dev/mediorum for local go dev workflow
2a5d881

Reduce mediorum image size by 75%
e987b67

Makefile and minor audiusd changes
6e109c3

Make sure analyze-bpm|key work
403a444

endline force-pushed the endl/pkg-mediorum branch from e5d1d74 to 403a444Compare October 4, 2024 15:29

endline merged commit c30c411 into mainOct 4, 2024

endline deleted the endl/pkg-mediorum branch October 4, 2024 15:32

samgutentag pushed a commit that referenced this pull request Nov 1, 2024
Move mediorum into top level audius-protocol go module (#9938)
fc99d68
Co-authored-by: endline <endline>

Navigation Menu

Uh oh!

Move mediorum into top level audius-protocol go module - #9938

Move mediorum into top level audius-protocol go module#9938
endline merged 11 commits into
mainfrom
endl/pkg-mediorum

endline commented Oct 2, 2024•
edited
Loading

Uh oh!

changeset-botBot commented Oct 2, 2024•
edited
Loading

Uh oh!

gitguardianBot commented Oct 2, 2024•
edited
Loading

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

alecsavvy left a comment

Uh oh!

audius-infra commented Oct 3, 2024

Uh oh!

audius-infra commented Oct 3, 2024

Uh oh!

phelpsdbOct 3, 2024

Uh oh!

Uh oh!

Uh oh!

endline commented Oct 3, 2024

Uh oh!

audius-infra commented Oct 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

endline commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-botBot commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gitguardianBot commented Oct 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

audius-infra commented Oct 2, 2024

Uh oh!

alecsavvy left a comment

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Oct 3, 2024

Uh oh!

audius-infra commented Oct 3, 2024

Uh oh!

phelpsdbOct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

endline commented Oct 3, 2024

Uh oh!

audius-infra commented Oct 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

endline commented Oct 2, 2024•
edited
Loading

changeset-botBot commented Oct 2, 2024•
edited
Loading

gitguardianBot commented Oct 2, 2024•
edited
Loading