Uh oh!
There was an error while loading. Please reload this page.
Finish SDK splitting - #9987
Conversation
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 1606950 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/production.ts | View secret |
| 1606950 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 1606950 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/production.ts | View secret |
| 1606950 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 2416685 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/staging.ts | View secret |
| 2460750 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/production.ts | View secret |
| 4714545 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/development.ts | View secret |
| 4714545 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 4714545 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/development.ts | View secret |
| 7150224 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/staging.ts | View secret |
| 7150224 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 7150224 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/staging.ts | View secret |
| 7150224 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 10622416 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 10622416 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 10622416 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/production.ts | View secret |
| 10622416 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/staging.ts | View secret |
| 10622417 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/scripts/generateServicesConfig.ts | View secret |
| 10622417 | Triggered | Generic High Entropy Secret | 883321a | packages/sdk/src/sdk/config/development.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
audius-infra
commented
Oct 8, 2024
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype |
185f3f3 to
bb6d8f5Comparebb6d8f5 to
883321aCompareaudius-infra
commented
Oct 8, 2024
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype |
1 similar comment
audius-infra
commented
Oct 8, 2024
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype |
audius-infra
commented
Oct 8, 2024
It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype |
Note: merging into feature branch
Description
sdk-old->sdk-legacylibs/src/sdkandsdk/src/sdk(using a folder-to-folder diff). I explicitly did not port diffs that were related to ripping out the Eth code in favor of theaudius/ethpackagesdk/distimports that are pulling libs components to pull fromsdk-legacyinsteadsdk-legacyto all packages that still need to import libs components. These will get removed/replaced with directsdkusage latersdkandsdk-legacypackages building without errorssdkpackage from stagingI will also follow up with another PR that removes all sdk components from
sdk-legacyand only exports the legacy libs components.How Has This Been Tested?
npm run verifyandnpm run build😁