Skip to content

Finish SDK splitting - #9987

Merged
schottra merged 10 commits into
feature-remove-libsfrom
pay-3474-sdk2libs
Oct 8, 2024
Merged

Finish SDK splitting#9987
schottra merged 10 commits into
feature-remove-libsfrom
pay-3474-sdk2libs

Conversation

@schottra

@schottraschottra commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

Note: merging into feature branch

Description

  • Renamed sdk-old -> sdk-legacy
  • Fixed SDK config generation after viem migration
  • Ported over all changes I could detect between libs/src/sdk and sdk/src/sdk (using a folder-to-folder diff). I explicitly did not port diffs that were related to ripping out the Eth code in favor of the audius/eth package
  • Updated all sdk/dist imports that are pulling libs components to pull from sdk-legacy instead
  • Added dependency on sdk-legacy to all packages that still need to import libs components. These will get removed/replaced with direct sdk usage later
  • Got sdk and sdk-legacy packages building without errors
  • Regenerated api code for sdk package from staging
  • Got web/mobile/common at least building. Not sure if they work correctly yet. Will follow up in another PR with any fixes needed there.

I will also follow up with another PR that removes all sdk components from sdk-legacy and only exports the legacy libs components.

How Has This Been Tested?

npm run verify and npm run build 😁

@changeset-bot

changeset-botBot commented Oct 8, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3d9247d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gitguardian

gitguardianBot commented Oct 8, 2024

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 19 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian idGitGuardian statusSecretCommitFilename
1606950TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/production.tsView secret
1606950TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
1606950TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/production.tsView secret
1606950TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
2416685TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/staging.tsView secret
2460750TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/production.tsView secret
4714545TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/development.tsView secret
4714545TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
4714545TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/development.tsView secret
7150224TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/staging.tsView secret
7150224TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
7150224TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/staging.tsView secret
7150224TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
10622416TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
10622416TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
10622416TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/production.tsView secret
10622416TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/staging.tsView secret
10622417TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/scripts/generateServicesConfig.tsView secret
10622417TriggeredGeneric High Entropy Secret883321apackages/sdk/src/sdk/config/development.tsView secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@audius-infra

Copy link
Copy Markdown
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype

@audius-infra

Copy link
Copy Markdown
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype

1 similar comment
@audius-infra

Copy link
Copy Markdown
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype

@schottra
schottra marked this pull request as ready for review October 8, 2024 20:08

@rickyromborickyrombo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible lift!!!! 💪

@audius-infra

Copy link
Copy Markdown
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @dylanjeffers@sliptype

@schottra
schottra merged commit a1af4d9 into feature-remove-libsOct 8, 2024
@schottra
schottra deleted the pay-3474-sdk2libs branch October 8, 2024 20:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@schottra@audius-infra@rickyrombo@raymondjacobson