Uh oh!
There was an error while loading. Please reload this page.
[PAY-3498] Fix remix track audience targeting - #9992
Merged
Conversation
|
dharit-tan
approved these changes
Oct 8, 2024
dharit-tan
left a comment
Contributor
There was a problem hiding this comment.
great!
i should really encode/decode IDs at api layer for other chats stuff too. have a ticket for that.
audius-infra
commented
Oct 8, 2024
Collaborator
Preview this change https://demo.audius.co/am-PAY-3498 |
audius-infra pushed a commit
that referenced
this pull request
Oct 12, 2024
[ae31aee] Fix Text component font and CAA API key (#10034) Marcus Pasell [3f7424e] [PAY-3501] Improvements to blast upgrade flow (#10025) Reed [e7c7778] [PAY-3481, PAY-3512] ChatBlastCTA float above mobile keyboard (#10029) Andrew Mendelsohn [ca3df1a] [PAY-3502] Toggle all boxes on when allowing all chats (#10028) Andrew Mendelsohn [973af51] [C-5170C-5175] Fix web pin action, update mute thread (#10032) Dylan Jeffers [120720f] [C-5143, C-5146] Comments QA 2 (#10022) Kyle Shanks [0a09b2a] [C-5140] Fix too big comment container (#10023) JD Francis [b93ad3c] Add New Comments button (#10021) Sebastian Klingler [617f845] [C-5145] Add comment count increment logic (#10018) JD Francis [237aa91] [C-5125, C-5147, C-5148] Web and Mobile Comment QA 1 (#10020) Kyle Shanks [f637b56] [C-5099] Pluralize the word replies correctly (#10019) JD Francis [a50db65] Remove duplicate turn off notifs (#10017) Sebastian Klingler [8db254b] [C-5100] Various comment reply fixes (#9956) JD Francis [977c618] [C-5079] Mute comments from user profile (#10009) Isaac Solo [bc3f1c7] Fix mobile web comments not displaying (#10015) Dylan Jeffers [f891f6e] [PAY-3220] Inbox unavailable UI for new chat permissions (#10012) Reed [708e3a1] [C-5129, C-5130] Add reply/mention push/email notifications (#9998) Dylan Jeffers [ff8f05c] [C-5186] Add autoFocus to ComposerInput (#10004) Dylan Jeffers [5f39cdc] Fix track comment notification setting (#10008) Dylan Jeffers [d83cfb2] [C-4958] Improve web comment disabled state (#10005) Dylan Jeffers [1051b96] [C-5030] Get new comment ID from api (#9999) Dylan Jeffers [7b82783] [C-5132] Add artist popover UserGeneratedTextV2 (#10006) Dylan Jeffers [b2b8f54] [PAY-3499, PAY-3500] Fix truncation on blasts with content audience (#10010) Andrew Mendelsohn [7511964] [PAY-3446] Fix back button in ChatBlastCTA (#10011) Andrew Mendelsohn [3ad4d63] [PAY-3203] Chat permissions write updates for multi-select (#9996) Reed [aebde5b] [C-5105] Fix issue with remixes lineup empty on track screen (#10001) Sebastian Klingler [3ccc0fb] [C-5124] Update ComposerInputs to check for user mentions before submitting IDs (#10007) Kyle Shanks [a08f347] [C-5114] [C-5115] Comment stat display improvements (#10003) Sebastian Klingler [40e803b] Update dapp-store build artifacts audius-infra [f630870] [PAY-3465] Fix text overflow on mobile ChatList (#9995) Andrew Mendelsohn [e8c8ed0] [C-5066C-5023] Refactor pinned comment, fix unpin (#9953) Dylan Jeffers [b8134a1] [PAY-3471] ChatBlastCTA should stick to the bottom (#9994) Andrew Mendelsohn [14035f6] [C-5107] Fix replying to a reply on mobile (#9993) Sebastian Klingler [22d1e90] [PAY-3498] Fix remix track audience targeting (#9992) Andrew Mendelsohn [974e457] [C-5119] Fix android comments drawer stacking (#9991) Sebastian Klingler [302e2b8] [PAY-3485] Show "View All" user list modal in audience display (#9985) Andrew Mendelsohn [a08e6b5] [C-5012] Refactor web track remixes UI (#9974) Dylan Jeffers [b6bf59b] [PAY-3491] Don't allow chat blast create with empty audience (#9941) Andrew Mendelsohn [06b4e90] [PAY-3484] Format audience counts (#9942) Andrew Mendelsohn [7fcb349] [C-5073] Fix issue with edit state persisting (#9981) Sebastian Klingler [acdb822] [C-5076] Fix issue with unpin message (#9982) Sebastian Klingler [ec2fe5d] Finish TextLink refactor on mobile (#9979) Sebastian Klingler [d18c3b4] [C-5069] Fix mobile ComposerInput border color on focus (#9978) Kyle Shanks [41b62a5] [PAY-3388] Re-land feed changes with mobile-compatible wallet update (#9976) Randy Schott [5f425fc] Revert "[PAY-3388] Migrate /feed to SDK" (#9973) Randy Schott [da9f48a] [C-5094] Press comment stat to navigate to comments (#9965) Sebastian Klingler [58dffe3] [PAY-3388] Migrate /feed to SDK (#9950) Randy Schott [c2f5f69] Fix comment lint (#9969) Dylan Jeffers [9d45442] [C-5046, C-5047] Add comment notification settings (#9882) Dylan Jeffers [ee070a7] Fix mobile lint (#9968) Dylan Jeffers [19698c8] Upgrade mobile apps to 117 (#9967) Dylan Jeffers
samgutentag pushed a commit
that referenced
this pull request
Nov 1, 2024
samgutentag pushed a commit
that referenced
this pull request
Nov 1, 2024
[ae31aee] Fix Text component font and CAA API key (#10034) Marcus Pasell [3f7424e] [PAY-3501] Improvements to blast upgrade flow (#10025) Reed [e7c7778] [PAY-3481, PAY-3512] ChatBlastCTA float above mobile keyboard (#10029) Andrew Mendelsohn [ca3df1a] [PAY-3502] Toggle all boxes on when allowing all chats (#10028) Andrew Mendelsohn [973af51] [C-5170C-5175] Fix web pin action, update mute thread (#10032) Dylan Jeffers [120720f] [C-5143, C-5146] Comments QA 2 (#10022) Kyle Shanks [0a09b2a] [C-5140] Fix too big comment container (#10023) JD Francis [b93ad3c] Add New Comments button (#10021) Sebastian Klingler [617f845] [C-5145] Add comment count increment logic (#10018) JD Francis [237aa91] [C-5125, C-5147, C-5148] Web and Mobile Comment QA 1 (#10020) Kyle Shanks [f637b56] [C-5099] Pluralize the word replies correctly (#10019) JD Francis [a50db65] Remove duplicate turn off notifs (#10017) Sebastian Klingler [8db254b] [C-5100] Various comment reply fixes (#9956) JD Francis [977c618] [C-5079] Mute comments from user profile (#10009) Isaac Solo [bc3f1c7] Fix mobile web comments not displaying (#10015) Dylan Jeffers [f891f6e] [PAY-3220] Inbox unavailable UI for new chat permissions (#10012) Reed [708e3a1] [C-5129, C-5130] Add reply/mention push/email notifications (#9998) Dylan Jeffers [ff8f05c] [C-5186] Add autoFocus to ComposerInput (#10004) Dylan Jeffers [5f39cdc] Fix track comment notification setting (#10008) Dylan Jeffers [d83cfb2] [C-4958] Improve web comment disabled state (#10005) Dylan Jeffers [1051b96] [C-5030] Get new comment ID from api (#9999) Dylan Jeffers [7b82783] [C-5132] Add artist popover UserGeneratedTextV2 (#10006) Dylan Jeffers [b2b8f54] [PAY-3499, PAY-3500] Fix truncation on blasts with content audience (#10010) Andrew Mendelsohn [7511964] [PAY-3446] Fix back button in ChatBlastCTA (#10011) Andrew Mendelsohn [3ad4d63] [PAY-3203] Chat permissions write updates for multi-select (#9996) Reed [aebde5b] [C-5105] Fix issue with remixes lineup empty on track screen (#10001) Sebastian Klingler [3ccc0fb] [C-5124] Update ComposerInputs to check for user mentions before submitting IDs (#10007) Kyle Shanks [a08f347] [C-5114] [C-5115] Comment stat display improvements (#10003) Sebastian Klingler [40e803b] Update dapp-store build artifacts audius-infra [f630870] [PAY-3465] Fix text overflow on mobile ChatList (#9995) Andrew Mendelsohn [e8c8ed0] [C-5066C-5023] Refactor pinned comment, fix unpin (#9953) Dylan Jeffers [b8134a1] [PAY-3471] ChatBlastCTA should stick to the bottom (#9994) Andrew Mendelsohn [14035f6] [C-5107] Fix replying to a reply on mobile (#9993) Sebastian Klingler [22d1e90] [PAY-3498] Fix remix track audience targeting (#9992) Andrew Mendelsohn [974e457] [C-5119] Fix android comments drawer stacking (#9991) Sebastian Klingler [302e2b8] [PAY-3485] Show "View All" user list modal in audience display (#9985) Andrew Mendelsohn [a08e6b5] [C-5012] Refactor web track remixes UI (#9974) Dylan Jeffers [b6bf59b] [PAY-3491] Don't allow chat blast create with empty audience (#9941) Andrew Mendelsohn [06b4e90] [PAY-3484] Format audience counts (#9942) Andrew Mendelsohn [7fcb349] [C-5073] Fix issue with edit state persisting (#9981) Sebastian Klingler [acdb822] [C-5076] Fix issue with unpin message (#9982) Sebastian Klingler [ec2fe5d] Finish TextLink refactor on mobile (#9979) Sebastian Klingler [d18c3b4] [C-5069] Fix mobile ComposerInput border color on focus (#9978) Kyle Shanks [41b62a5] [PAY-3388] Re-land feed changes with mobile-compatible wallet update (#9976) Randy Schott [5f425fc] Revert "[PAY-3388] Migrate /feed to SDK" (#9973) Randy Schott [da9f48a] [C-5094] Press comment stat to navigate to comments (#9965) Sebastian Klingler [58dffe3] [PAY-3388] Migrate /feed to SDK (#9950) Randy Schott [c2f5f69] Fix comment lint (#9969) Dylan Jeffers [9d45442] [C-5046, C-5047] Add comment notification settings (#9882) Dylan Jeffers [ee070a7] Fix mobile lint (#9968) Dylan Jeffers [19698c8] Upgrade mobile apps to 117 (#9967) Dylan Jeffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The migration to the new remixers endpoint broke the options in the form.
The root cause was we weren't decoding the hashIds after receiving the data. Trying to call
encodeHashIdon the hashId resulted in''which was submitted as the target trackId for the chatBlast audience.How Has This Been Tested?
wasn't working now it's working 👍