Uh oh!
There was an error while loading. Please reload this page.
fix: add UTF-8 encoding for subprocess calls on Windows - #139
fix: add UTF-8 encoding for subprocess calls on Windows#139cabana8471-arch wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughAdds explicit UTF-8 encoding and error replacement parameters to subprocess invocations across three initialization and startup modules to resolve Windows CP1252 encoding issues. No control flow changes; parameters ensure robust text I/O handling on Windows environments. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…toForgeAI#139) Align the final_verdict enum values with the app spec (passed|failed|error). The implementation previously used 'partial' instead of 'error'. Changes: - api/agentspec_models.py: VERDICT constant and column comment - server/schemas/agentspec.py: VERDICTS Literal type and validator - api/validators.py: Verdict determination logic in AcceptanceGate - api/harness_kernel.py: Verdict logic in _run_acceptance_validators and _run_partial_acceptance_validators - api/agentspec_crud.py, api/migration_flag.py, api/event_recorder.py: Docstring updates - ui/src/lib/types.ts: AgentRunVerdict TypeScript type - Updated all test assertions from 'partial' to 'error' - All 3488 existing tests continue to pass (no regressions) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
On Windows, subprocess.Popen/run with text=True defaults to CP1252 encoding instead of UTF-8. This causes UnicodeDecodeError when Claude outputs characters outside the CP1252 codepage. Add explicit encoding="utf-8" and errors="replace" parameters to all subprocess calls that use text=True. Files modified: - parallel_orchestrator.py (3 locations) - start.py (2 locations) - start_ui.py (1 location) ClosesAutoForgeAI#138 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5c6e875 to
a4e1a54Compare
Summary
encoding="utf-8"anderrors="replace"to all subprocess calls that usetext=TrueProblem
Windows users experience
UnicodeDecodeErrorwhen running parallel mode becausesubprocess.Popenwithtext=Truedefaults to CP1252 encoding instead of UTF-8.Solution
Explicitly specify UTF-8 encoding for all subprocess calls that process text output from Claude agents.
Files Modified
parallel_orchestrator.py(3 locations)start.py(2 locations)start_ui.py(1 location)Testing
ruff check parallel_orchestrator.py start.py start_ui.pyNotes
quality_gates.py,git_workflow.py,review_agent.py, andsecurity_scanner.pymentioned in issue Encoding issue with CP1252 / UTF-8 #138 don't exist on master - they are only in feature branches. This PR fixes all affected files on master.Closes#138
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.