Skip to content

Wrong type annotation #2

Description

@paoloq

Hi, I encountered an error caused by a wrong type annotation.

def get_authorization_url(
client_id: str, response_type: str, redirect_uri: str,
scopes: list[Scope], state: str = None
) -> str

As you can see in the case above, list[Scope] causes a runtime error because list is not the right way to type annotate.
It should be changed in List, imported from typing.

I'm going to PR a fix in few minutes, I created this issue just for completeness.

Btw, thanks for starting this great work in creating an SDK for Forge API.
I'm likely to start contributing in next weeks as I'll need it for a new project.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions