Fixes for bug 147 - #148
Merged
Merged
Conversation
…ray was allowing unboxing of an array with a single item, which stripped the array brackets from the JSON. The array is now forced, meaning the output JSON will always have an array if the source JSON had an array.
Contributor
Author
|
There are 3 tests failing locally in the The tests I added are passing fine. They do a few extra asserts to make sure the arrays in the source JSON come back as arrays in the modified JSON. |
Member
|
No worries, I will check this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Conversion back from an OrderedHashSet to an array was allowing unboxing of an array with a single item, which stripped the array brackets from the JSON. The array is now forced, meaning the output JSON will always have an array if the source JSON had an array.