Skip to content

Add a SetSecretClientOptions to the AzureAppConfigurationKeyVaultOptions #274

Description

@acgritt

I know this was partially covered in #232 but it would be better to provide an extension to supply default SecretClientOptions for the setup. This way we could write:

options.Connect(appConfigUrl, credential)
  .ConfigureKeyVault(vault =>
  {
    vault
      .SetCredential(credential)
      .SetSecretClientOptions(clientOptions);
  });

Using the AzureAppConfigurationKeyVaultOptions.Register(SecretClient) has the drawback of the client code having to know what all the key vault connections are at startup. Rather than allowing that to be masked behind the App Configuration and it just being a matter of the credential having permissions to talk to the various key vaults.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions