Add enhanced feature flag import support - #26
Open
Christine Wanjau (ChristineWanjau) wants to merge 9 commits into
Open
Christine Wanjau (ChristineWanjau) wants to merge 9 commits into
Christine Wanjau (ChristineWanjau) wants to merge 9 commits into
Conversation
Christine Wanjau (ChristineWanjau)
force-pushed
the
feature/enhanced-feature-flags
branch
from
August 24, 2026 14:51
6f8dc19 to
faa2265
Compare
added 3 commits
August 25, 2026 14:55
…pping, stream kvset guard - Add ReadableStreamFeatureFlagSource and FileFeatureFlagSource specs with ffset/default fixtures - Fix StringFeatureFlagSource.setFilterOptions to use FfSet (not dead KvSet branch) for wildcard filters - Map MS FM allocation to camelCase in DefaultFeatureFlagsConverter - Reject KvSet at construction in ReadableStreamFeatureFlagSource
Christine Wanjau (ChristineWanjau)
marked this pull request as ready for review
August 25, 2026 18:57
added 3 commits
August 25, 2026 21:58
Resolves eslint indent errors in readableStreamFeatureFlagSource and stringFeatureFlagSource.
Use sinon .rejects() and await the server-error import so a synchronous throw no longer escapes AdaptiveTaskManager and surfaces as an uncaught rejection in later tests (ERR_MOCHA_MULTIPLE_DONE).
Christine Wanjau (ChristineWanjau)
requested review from
Maryanne Gichohi (MaryanneNjeri) and
Jimmy Campbell (jimmyca15)
September 1, 2026 11:26
| * @param options - Import options including timeout, progress callback, strict mode, and import mode. | ||
| * @returns Promise<void> | ||
| */ | ||
| public async Import(featureFlagSource: FeatureFlagSource, options: FeatureFlagImportOptions): Promise<void> { |
There was a problem hiding this comment.
Suggested change
| public async Import(featureFlagSource: FeatureFlagSource, options: FeatureFlagImportOptions): Promise<void> { | |
| public async Import(featureFlagsSource: FeatureFlagSource, options: FeatureFlagImportOptions): Promise<void> { |
Contributor
Author
There was a problem hiding this comment.
Updated
| * | ||
| * @returns Collection of FeatureFlagParam or FeatureFlagChange objects. | ||
| */ | ||
| GetFeatureFlags(): Promise<FeatureFlagParam[] | FeatureFlagChange[]>; |
There was a problem hiding this comment.
In the configuration setting path the name is SetConfigurationSettingParam. What is the reason for the different pattern here?
Comment on lines
+32
to
+35
| /** @internal */ | ||
| export function getSettingIdentity(nameOrKey: string, label?: string): string { | ||
| return `${nameOrKey}\u0000${label ?? ""}`; | ||
| } |
There was a problem hiding this comment.
Should just be private helper in the respective importer. No need to generalize cross name and key.
Contributor
Author
There was a problem hiding this comment.
Sure. Updated
Comment on lines
+37
to
+42
| /** @internal */ | ||
| export function validateImportMode(importMode: ImportMode): void { | ||
| if (importMode !== ImportMode.IgnoreMatch && importMode !== ImportMode.All) { | ||
| throw new ArgumentError("Only options supported for Import Mode are 'All' and 'Ignore-Match'."); | ||
| } | ||
| } |
There was a problem hiding this comment.
This should be in a helper named validation.ts
Contributor
Author
There was a problem hiding this comment.
Added validation.ts
Comment on lines
+44
to
+70
| /** @internal */ | ||
| export function createAdaptiveTaskManager<TValue, TResult>( | ||
| task: (value: TValue) => Promise<TResult>, | ||
| values: TValue[] | ||
| ): AdaptiveTaskManager<TResult> { | ||
| let index = 0; | ||
| return new AdaptiveTaskManager(() => { | ||
| if (index === values.length) { | ||
| return undefined; | ||
| } | ||
| const value = values[index++]; | ||
| return () => task(value); | ||
| }, values.length); | ||
| } | ||
|
|
||
| /** @internal */ | ||
| export async function executeTasksWithTimeout<T>( | ||
| taskManager: AdaptiveTaskManager<T>, | ||
| timeInSeconds: number, | ||
| callback?: (progress: ImportProgress) => unknown | ||
| ): Promise<void> { | ||
| let timer: NodeJS.Timeout; | ||
| const timeoutPromise = new Promise((_, reject) => { | ||
| timer = setTimeout(() => reject(new OperationTimeoutError()), timeInSeconds * 1000); | ||
| }); | ||
| await Promise.race([taskManager.Start(callback), timeoutPromise]).finally(() => clearTimeout(timer)); | ||
| } |
There was a problem hiding this comment.
TaskManagement.ts
Contributor
Author
There was a problem hiding this comment.
Added TaskManagement.ts
| } | ||
|
|
||
| /** @internal */ | ||
| export function isChangeArray<TChange>(value: unknown): value is TChange[] { |
There was a problem hiding this comment.
Can we use Any instead? Looks like a type that exists somewhere when TChange is used.
Contributor
Author
There was a problem hiding this comment.
Yes. Updated
Jimmy Campbell (jimmyca15)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeatureFlagImporterusingFeatureFlagClientfrom@azure/app-configuration1.13.0-beta.1appconfig/ffsetserialized feature flag sources with rootprofiledetectionprofile: appconfig/kvsetfor KVSet documents and add FFSet validation and design documentation