Skip to content

Adding discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests - #635

Merged
Jesper Fajers (Jefajers) merged 3 commits into
Azure:mainfrom
Jefajers:Microsoft.Authorization/roleEligibilityScheduleRequests
May 22, 2022
Merged

Adding discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests#635
Jesper Fajers (Jefajers) merged 3 commits into
Azure:mainfrom
Jefajers:Microsoft.Authorization/roleEligibilityScheduleRequests

Conversation

@Jefajers

@JefajersJesper Fajers (Jefajers) commented May 21, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Overview/Summary

Adds discovery support for resource type: roleEligibilityScheduleRequests.
Closes#476

This PR fixes/adds/changes/removes

  1. Adds new setting called SkipPim with default set to $true. Ensures that any discovery of Privileged Identity Management resources requires opt-in; change setting to $false.
  2. Adds functional test for pull and push of roleEligibilityScheduleRequests.
  3. Changes wiki settings docs.

Breaking Changes

N/A

Testing Evidence

Testing has been performed; final evidence is presented during automated functional testing included in PR.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the mainbranch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@JefajersJesper Fajers (Jefajers) added the enhancement New feature or request label May 21, 2022
@Jefajers
Jesper Fajers (Jefajers) temporarily deployed to test May 21, 2022 14:20 Inactive
@JefajersJesper Fajers (Jefajers) changed the title Add discovery support for Microsoft.Authorization/roleEligibilityScheduleRequestsAdding discovery support for Microsoft.Authorization/roleEligibilityScheduleRequestsMay 21, 2022
@daltondhcp
Johan Dahlbom (daltondhcp) temporarily deployed to test May 22, 2022 13:11 Inactive
@JefajersJesper Fajers (Jefajers) mentioned this pull request May 22, 2022
Merged
@Jefajers
Jesper Fajers (Jefajers) temporarily deployed to test May 22, 2022 16:20 Inactive
daltondhcp
Johan Dahlbom (daltondhcp) approved these changes May 22, 2022
View reviewed changes

@daltondhcpJohan Dahlbom (daltondhcp) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚢

@Jefajers
Jesper Fajers (Jefajers) merged commit 61755e9 into Azure:mainMay 22, 2022
@Jefajers
Jesper Fajers (Jefajers) deleted the Microsoft.Authorization/roleEligibilityScheduleRequests branch May 24, 2022 16:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltondhcpJohan Dahlbom (daltondhcp)daltondhcp approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

Release - v1.8.0

Development

Successfully merging this pull request may close these issues.

Add discovery support for Microsoft.Authorization/roleEligibilityScheduleRequests

2 participants

@Jefajers@daltondhcp