Uh oh!
There was an error while loading. Please reload this page.
Bump @typescript-eslint/eslint-plugin from 8.66.0 to 8.67.0 - #2737
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dependabot (@dependabot) rebase |
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 8.66.0 to 8.67.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.67.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.67.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
354cbc3 to
3a56f04CompareCopilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:
|
Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:
|
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Done. This bumps the lockfile-resolved
Self-rating: 9/10 — correctness, build/lint health, and changelog accuracy are solid; docked one point since there's no dedicated test to add for a lint-tooling patch bump (none is meaningfully possible here). Risk of not applying this update is low (minor lint rule/perf fixes upstream), but keeping dev tooling current avoids future compounding upgrade pain. |
Updated the changelog instruction to emphasize a concise summary of code changes.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ChangeLog.md:40
- Sentence after the period should be capitalized for correct grammar ("Updated", not "updated").
- Bumped `cross-env` dev dependency from `^7.0.3` to `^10.1.0`. Cross-env 10 is ESM-only and moved its bin scripts from `src/bin/` to `dist/bin/`. updated `tests/packageScripts.test.ts` to resolve the `cross-env-shell` script from cross-env's declared `bin` mapping.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (3)
ChangeLog.md:40
- Sentence after the second period starts with lowercase
updated, which reads like a typo in the changelog. Capitalize it (and consider keeping the same sentence structure/tone as nearby entries).
- Bumped `cross-env` dev dependency from `^7.0.3` to `^10.1.0`. Cross-env 10 is ESM-only and moved its bin scripts from `src/bin/` to `dist/bin/`. updated `tests/packageScripts.test.ts` to resolve the `cross-env-shell` script from cross-env's declared `bin` mapping.
ChangeLog.md:44
- This bullet mixes verb tenses:
bumped ... and dedupe .... For readability/grammar, use consistent past tense (e.g.,... and deduped ...) and consider adding a comma before the final clause if keeping it as a single long sentence.
- Relaxed the `serialize-javascript` override from the exact `7.0.3` pin to `^7.0.7` (resolves to 7.1.0) to remediate GHSA-qj8w-gfj5-8c6v (CPU-exhaustion DoS, affects 5.0.0 - 7.0.4), and bumped `mocha` dev dependency from `12.0.0-rc.5` to `12.0.0-rc.6` and dedupe the transitive `serialize-javascript`/`iconv-lite` copies.
.github/copilot-dependabot-instructions.md:7
- The phrase
concise/crispis a bit ambiguous for contributors (and mixes two similar adjectives). Consider simplifying to a single unambiguous instruction (e.g., justconcise) to reduce interpretation differences.
5. **Changelog** — append one bullet to `ChangeLog.md` under `## Upcoming Release` → `General:`, matching the existing style and tone of the entries already there (package name in backticks, old → new version, why, and a one-line concise/crisp summary of any code changes made).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ChangeLog.md:46
- Minor: this entry reads like a
package.jsonversion bump, butpackage.jsonstill declares^8.65.0for both packages (the change is a lockfile-resolved update). To match the wording used for@types/nodeabove, consider rephrasing this as a lockfile-resolved update for accuracy.
- Bumped the `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` dev dependencies from 8.66.0 to 8.67.0 (declared `package.json` ranges remain `^8.65.0`).
Uh oh!
There was an error while loading. Please reload this page.
Bumps @typescript-eslint/eslint-plugin from 8.66.0 to 8.67.0.
Release notes
Sourced from @typescript-eslint/eslint-plugin's releases.
Changelog
Sourced from @typescript-eslint/eslint-plugin's changelog.
Commits
20a261fchore(release): publish 8.67.06dfe4d0chore(eslint-plugin-internal): [plugin-test-formatting] enforce zero-indentat...3b155bbchore: use typescript 7 for typechecking (#12601)