Uh oh!
There was an error while loading. Please reload this page.
Bump morgan from 1.11.0 to 1.12.0 - #2761
Conversation
Bumps [morgan](https://github.com/expressjs/morgan) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/expressjs/morgan/releases) - [Changelog](https://github.com/expressjs/morgan/blob/master/HISTORY.md) - [Commits](expressjs/morgan@1.11.0...1.12.0) --- updated-dependencies: - dependency-name: morgan dependency-version: 1.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Akanksha Jain (jainakanksha-msft)
commented
Sep 1, 2026
Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:
Impact analysis
Build/Conflict Issues
Tests
Run the Suite
Changelog
Comments
Self-Rate
Summary
|
…an 1.12.0 Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Completed in 51c92d9.
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is limited to a lockfile security update plus targeted regression tests and a changelog entry, with no production code modifications.
Impact analysis
- Package:
morgan - Version change:
1.11.0→1.12.0(lockfile-resolved) - Usage: Access logging via
morgan("common", { stream: this.accessLogWriteStream })in Blob/Queue/Table request listener factories - Impact and risk: Applies upstream escaping fixes for token values to mitigate log forging; risk is limited to access-log output formatting changes for affected characters.
- Package:
Build and conflict resolution
- Commands run: - None
- Issues found: - None
- Result: - Not run in this review environment
Tests
- Tests added or updated: -
tests/common/accessLog.test.ts - Coverage: - Adds regression coverage for escaped access-log token values (Unicode line separators and ASCII control chars)
- Result: - Not run in this review environment
- Tests added or updated: -
Test suite
- Commands run: - None
- Passing: - None
- Pending or failing: - Not run in this review environment
Changelog
- Entry added: - Yes
- Location: -
ChangeLog.md→## Upcoming Release→General
PR comments
- Threads reviewed: - None
- Actions taken: - None
- Unresolved items: - None
Self-rating
- Score: - 8/10
- Reasoning: - Straightforward dependency security update with clear regression tests; limited residual risk due to upstream behavior changes affecting log output.
Iteration
- Improvements made after self-review:
- None
- Improvements made after self-review:
Summary
- Why the update matters: - Addresses CVE-2026-15603 by ensuring access-log token values are safely escaped, preventing log record forgery.
- Risk if not applied: - Potential for attacker-controlled values (e.g., Unicode line separators) to forge additional access log lines in downstream log parsers.
- Final status: - Ready to approve
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
Akanksha Jain (jainakanksha-msft)
commented
Sep 2, 2026
Copilot do we really need that test file? |
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
You're right — I removed it in c137756. The test spun up its own Express app with The PR is now lockfile-only plus the ChangeLog entry, which I also updated to drop the mention of the removed test coverage. |
There was a problem hiding this comment.
🟡 Changes recommended
The CVE remediation is currently lockfile-only while package.json still declares morgan as ^1.11.0, which can allow downstream installs/consumer lockfiles to remain on 1.11.x and makes the changelog note potentially misleading.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
| General: | ||
| - Updated the lockfile-resolved `morgan` version from 1.11.0 to 1.12.0 to fix log forging via Unicode line separators (U+0085, U+2028, U+2029) in access log tokens (CVE-2026-15603). Lockfile-only change, no source changes required. |
There was a problem hiding this comment.
Copilot could you please validate this comment and take necessary action
There was a problem hiding this comment.
Validated and applied. I updated the declared dependency from morgan: ^1.11.0 to ^1.12.0 in package.json (and aligned package-lock.json), then updated the changelog entry to reflect that this is not lockfile-only. Addressed in commit e5dde12.
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The PR is a straightforward dependency + lockfile update with an accurate changelog entry and no code-path changes in Azurite itself.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
Uh oh!
There was an error while loading. Please reload this page.
Bumps morgan from 1.11.0 to 1.12.0.
Release notes
Sourced from morgan's releases.
Changelog
Sourced from morgan's changelog.
Commits
063f0841.12.0 (#376)fbf9383fix: escape all token values in log output0338399feat: NO_COLOR env var removes color in dev format (#377)51007f9feat: pass objects through to streams in objectMode (#375)4790f5dci: use latest patch per Node.js major, add 23-26 (#374)786c66ddocs: fix README lint errors (#373)98d848cdocs: add ES modules import example (#352)fb9a228chore(ci): npm-publish via reusable workflows (#334)4729fe8build: bump github actions and dev dependencies (#369)bd171d7docs: update link (#363)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for morgan since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)