Uh oh!
There was an error while loading. Please reload this page.
Bump lint-staged from 17.3.0 to 17.4.1 - #2762
Conversation
Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 17.3.0 to 17.4.1. - [Release notes](https://github.com/lint-staged/lint-staged/releases) - [Changelog](https://github.com/lint-staged/lint-staged/blob/main/CHANGELOG.md) - [Commits](lint-staged/lint-staged@v17.3.0...v17.4.1) --- updated-dependencies: - dependency-name: lint-staged dependency-version: 17.4.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Akanksha Jain (jainakanksha-msft)
commented
Sep 1, 2026
Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:
Impact analysis
Build/Conflict Issues
Tests
Run the Suite
Changelog
Comments
Self-Rate
Summary
|
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Done in 7d71e24.
|
| import * as path from "path"; | ||
| const repoRoot = path.resolve(__dirname, ".."); | ||
| const lintStagedBin = path.resolve( |
There was a problem hiding this comment.
Copilot DO you really think this test file is needed which is specific to lint configuration testing on;y
There was a problem hiding this comment.
I agree this was too specific. I removed tests/lintStagedConfig.test.ts and consolidated the needed guard into tests/packageScripts.test.ts in d75fa38.
There was a problem hiding this comment.
🟡 Changes recommended
The new failure-case test currently validates working-tree content (not index/staged content) and the git helper’s failure message omits spawn errors, reducing test correctness and diagnosability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
| assert.strictEqual( | ||
| fs.readFileSync(path.join(workspace, "broken.json"), "utf8"), | ||
| "{ invalid json\n", | ||
| "lint-staged must restore the original staged content on failure" | ||
| ); |
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Addressed in d75fa38. I re-ran |
| General: | ||
| - Updated the lockfile-resolved `lint-staged` version from 17.3.0 to 17.4.1, which picks up the fixed `picomatch` 4.0.7 and `tinyexec` 1.3.0 dependencies used for staged-file matching and task execution; consolidated coverage into `tests/packageScripts.test.ts` to keep `.lintstagedrc` on the supported flat glob-to-command format. |
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is limited to a lockfile resolution update plus a small, consistent regression test that matches the current .lintstagedrc format.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
Uh oh!
There was an error while loading. Please reload this page.
Bumps lint-staged from 17.3.0 to 17.4.1.
Release notes
Sourced from lint-staged's releases.
Changelog
Sourced from lint-staged's changelog.
Commits
d0c1517Merge pull request #1841 from lint-staged/changeset-release/mainf061335chore(changeset): released2721afMerge pull request #1840 from lint-staged/updatesefe5b63ci: update Changesets action because it failed to publishcd76ce3build: update dependenciesea195e1Merge pull request #1837 from lint-staged/changeset-release/maina6a0d61chore(changeset): release0a09098Merge pull request #1832 from lint-staged/add-all-flag7fd685bfix: further fix parsing options logic510a27cfeat: add--allflag for including all files tracked by Git instead of just...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)