Skip to content

Storage Account: Parameterized support for HTTPs - #1052

Merged
Marius Storhaug (MariusStorhaug) merged 1 commit into
mainfrom
users/mast/SA_NFSShare
Feb 28, 2022
Merged

Marius Storhaug (MariusStorhaug) merged 1 commit into
mainfrom
users/mast/SA_NFSShare

Conversation

@MariusStorhaug

Copy link
Copy Markdown
Contributor

Change

Added supportsHttpsTrafficOnly as an optional parameter, was hardcoded. This should be optional as when you are using NFS file shares, it cannot be enabled.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions

github-actions Bot commented Feb 28, 2022

Copy link
Copy Markdown

Unit Test Results

    1 files    1 suites   2m 10s ⏱️
  42 tests 42 ✔️     0 💤 0
386 runs  42 ✔️ 344 💤 0

Results for commit 615bd7d.

♻️ This comment has been updated with latest results.

@MariusStorhaug
Marius Storhaug (MariusStorhaug) deleted the users/mast/SA_NFSShare branch February 28, 2022 11:51
@MariusStorhaug
Marius Storhaug (MariusStorhaug) restored the users/mast/SA_NFSShare branch March 1, 2022 21:31
@AlexanderSehr
Alexander Sehr (AlexanderSehr) deleted the users/mast/SA_NFSShare branch March 2, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants