NSG: Moved NSG Security Rules into its own child-module

[Alexander Sehr (AlexanderSehr)]

Change

• Moved NSG Security Rules into its own child-module

Pipeline reference

Type of Change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update (Wiki)

[github-actions]

Unit Test Results

  1 files  ±  0  1 suites  ±0   25s ⏱️ -15s
  6 tests ±  0  6 ✔️ ±0    0 💤 ±  0  0 ❌ ±0 
70 runs   - 31  6 ✔️ ±0  64 💤  - 31  0 ❌ ±0 

Results for commit ba4a780. ± Comparison against base commit 75bfc7e.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways/connections] used resource type [vpnGateways/vpnConnections] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways/natRules] used resource type [vpnGateways/natRules] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways/natRules] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways/vpnConnections] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/vpnGateways] used resource type [vpnGateways] should use on of the recent API version(s). Currently using [2021-05-01]

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkSecurityGroups/securityRules] used resource type [networkSecurityGroups/securityRules] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkSecurityGroups] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkSecurityGroups] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkSecurityGroups] used resource type [networkSecurityGroups/securityRules] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkSecurityGroups] used resource type [networkSecurityGroups] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/networkSecurityGroups] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]

♻️ This comment has been updated with latest results.

[Erika Gressi (eriqua)]

Should also the VM cross referenced nsg be updated? I understand there are already cuncurrent PRs on that one

[Alexander Sehr (AlexanderSehr)]

Should also the VM cross referenced nsg be updated? I understand there are already cuncurrent PRs on that one

Hey Erika Gressi (@eriqua) , do you refer to this one #1092? Not sure what to do there exactly. Seems to be only covering NICs. I'd at least not block this PR for the other one.

[Alexander Sehr (AlexanderSehr)]

Related to a similar issue with #1112 .

[Erika Gressi (eriqua)]

🆗