Skip to content

[Modules] Downgrade RBAC API version - #1358

Merged
Erika Gressi (eriqua) merged 5 commits into
mainfrom
users/erikag/rbac-link
May 4, 2022
Merged

Erika Gressi (eriqua) merged 5 commits into
mainfrom
users/erikag/rbac-link

Conversation

@eriqua

@eriqua Erika Gressi (eriqua) commented May 3, 2022

Copy link
Copy Markdown
Contributor

Description

Downgrade roleAssignment Api version from 2021-04-01-preview to 2020-10-01-preview.

Reasons:

  • 2020-10-01-preview is the latest documented in the Azure Resource Reference (ARR). Module readmes are linking ARR docs to the api version used and this is currently providing documentation to a different version than the one deployed.
  • 2020-10-01-preview fixes the warning on the roleAssignment Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2021-04-01-preview" does not have types available.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers
DesktopVirtualization: HostPools
Resources: ResourceGroups

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua Erika Gressi (eriqua) added bug Something isn't working documentation Improvements or additions to documentation [cat] modules category: modules labels May 3, 2022
@eriqua Erika Gressi (eriqua) self-assigned this May 3, 2022
@eriqua
Erika Gressi (eriqua) enabled auto-merge (squash) May 3, 2022 17:40
@ahmadabdalla

Copy link
Copy Markdown
Contributor

Erika Gressi (@eriqua) since its updating the docos as well, linter detected some language expression recommendations. Do you wanna update those as well?

@eriqua
Erika Gressi (eriqua) merged commit a443c7f into main May 4, 2022
@eriqua
Erika Gressi (eriqua) deleted the users/erikag/rbac-link branch May 4, 2022 15:54
@AlexanderSehr Alexander Sehr (AlexanderSehr) changed the title Downgrade RBAC Api version [Modules] Downgrade RBAC Api version Jun 17, 2022
@AlexanderSehr Alexander Sehr (AlexanderSehr) changed the title [Modules] Downgrade RBAC Api version [Modules] Downgrade RBAC API version Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants