[Modules] Service bus private networking ACL - #1453

Merged

Marius Storhaug (MariusStorhaug) merged 41 commits into

ChrisSidebotham:service-bus-private-networking

Jul 7, 2022

ChrisSidebotham-MSFT (ChrisSidebotham) commented May 31, 2022 •

edited

Loading

Contributor

Description

Private Networking for Azure Service Bus

Adding of the networkRuleSets Module to allow network configurations to be dynamically created for Azure Service Bus based on SKU and Private Endpoint

Pipeline references

Pipeline

https://github.com/ChrisSidebotham/ResourceModules/actions/runs/2410217790

Type of Change

Please delete options that are not relevant.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Update to documentation

Checklist

I'm sure there are no other open Pull Requests for the same update/change
My corresponding pipelines / checks run clean and green without any errors or warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (readme)
I did format my code

ChrisSidebotham-MSFT (ChrisSidebotham) added 7 commits

May 30, 2022 16:12


          Added ACL Config based on private endpoint config

440e6c0


          Static Validation Config

2876da4


          Added trailing '.'

fd641ab


          updated metadata descriptions

94469ef


          updated default ruleset param

c1a2fc0


          Replaced Globals for PR

f9e4610


          Merge branch 'main' into service-bus-private-networking

dc53461

Alexander Sehr (AlexanderSehr) assigned ChrisSidebotham-MSFT (ChrisSidebotham)

Alexander Sehr (AlexanderSehr) added enhancement [cat] modules labels

Marius Storhaug (MariusStorhaug) enabled auto-merge (squash)

June 1, 2022 07:57

Erika Gressi (eriqua) changed the title ~~Service bus private networking ACL~~ [Module] Service bus private networking ACL

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/deploy.bicep

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/deploy.bicep Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/deploy.bicep Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/networkRuleSets/readme.md Outdated

ChrisSidebotham-MSFT (ChrisSidebotham) and others added 5 commits

June 1, 2022 14:29


          removed whitespace

46ebf09

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>


          Applied suggestions from @eriqua

6d4a446

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>


          Added param for Azure Trusted Services

6ca5b3e

Trusted Services set default is true


          updated readme to matech changes in #6d4a446

ae572b7


          Updated version following new param addition

cea8697

Marius Storhaug (MariusStorhaug) previously requested changes

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/deploy.bicep Outdated

arm/Microsoft.ServiceBus/namespaces/deploy.bicep Outdated

arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep Outdated

arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep Outdated

arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep Outdated

arm/Microsoft.ServiceBus/namespaces/networkRuleSets/readme.md Outdated

arm/Microsoft.ServiceBus/namespaces/version.json Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/readme.md Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/deploy.bicep Outdated

Alexander Sehr (AlexanderSehr) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/.parameters/parameters.json Outdated


          Apply suggestions from Marius code review

3c69a58

NetworkACL => NetworkRuleSet
Version Change

Co-authored-by: Marius Storhaug <marstor@hotmail.com>

Erika Gressi (eriqua) reviewed

View reviewed changes

Erika Gressi (eriqua) left a comment

Contributor

Further team discussion needed to align on the implementation as this fits into a wider topic (ref issue #819)

ChrisSidebotham-MSFT (ChrisSidebotham) and others added 2 commits

June 6, 2022 12:29


          Apply suggestions from Marius code review

4ec874e

Friendly name of resource change to match resource type

Co-authored-by: Marius Storhaug <marstor@hotmail.com>


          Update arm/Microsoft.ServiceBus/namespaces/networkRuleSets/readme.md

134230a

Removed TODO's

Co-authored-by: Marius Storhaug <marstor@hotmail.com>


          merge of secure defaults & param overide

f86ba6d

ChrisSidebotham-MSFT (ChrisSidebotham) requested a review from Alexander Sehr (AlexanderSehr)

June 10, 2022 08:21

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/networkRuleSets/deploy.bicep Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

arm/Microsoft.ServiceBus/namespaces/deploy.bicep Outdated

Erika Gressi (eriqua) mentioned this pull request

[Feature Request]: Publish Release 0.6 #1533

Closed

15 tasks

Erika Gressi (eriqua) mentioned this pull request

[Modules] Servicebus: Added Customer-Managed-Key & additional resource type handling for removal #1586

Merged

4 tasks


          Updated params on child module per request from Erika

11e70d1

ChrisSidebotham-MSFT (ChrisSidebotham) requested a review from a team as a code owner

July 5, 2022 12:00

ChrisSidebotham-MSFT (ChrisSidebotham) and others added 4 commits

July 6, 2022 09:48


          Merge branch 'main' into service-bus-private-networking

c673387


          Moved from ARM to modules due to Breaking change

1e2c901


          Updated version.json

fe623dc

Committed in error merging latest changes from Azure:/main


          Updated friendly resource name

deb5351

ChrisSidebotham-MSFT (ChrisSidebotham) removed request for Alexander Sehr (AlexanderSehr) and Marius Storhaug (MariusStorhaug)

July 6, 2022 10:16

Erika Gressi (eriqua) reviewed

View reviewed changes

modules/Microsoft.ServiceBus/namespaces/deploy.bicep Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

modules/Microsoft.ServiceBus/namespaces/.test/parameters.json Outdated

ChrisSidebotham-MSFT (ChrisSidebotham) and others added 2 commits

July 6, 2022 11:36


          Update condition on nsr deployments

b1b9558

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>


          Update params template

8a8b24b

params set as defaults in code

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

Alexander Sehr (AlexanderSehr) reviewed

View reviewed changes

modules/Microsoft.ServiceBus/namespaces/.test/parameters.json Outdated


          fixed json formatting

2b286cf

Alexander Sehr (AlexanderSehr) reviewed

View reviewed changes

modules/Microsoft.ServiceBus/namespaces/deploy.bicep


          Adding param for reinforced telemetry

d741873

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

Erika Gressi (eriqua) reviewed

View reviewed changes

modules/Microsoft.ServiceBus/namespaces/readme.md Outdated

Erika Gressi (eriqua) reviewed

View reviewed changes

modules/Microsoft.ServiceBus/namespaces/readme.md


          Updated readme.md file for module

ed7cf76

Erika Gressi (eriqua) approved these changes

View reviewed changes

Erika Gressi (eriqua) left a comment

Contributor

🆗

Erika Gressi (eriqua) requested a review from Marius Storhaug (MariusStorhaug)

July 7, 2022 11:13

Erika Gressi (eriqua) dismissed Marius Storhaug (MariusStorhaug)’s stale review

July 7, 2022 11:14

All conversations resolved

Marius Storhaug (MariusStorhaug) merged commit b0505a6 into Azure:main

ChrisSidebotham-MSFT (ChrisSidebotham) deleted the service-bus-private-networking branch

July 7, 2022 11:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules enhancement