Skip to content

[Modules] DataFactory: Added private endpoints & customer-managed-key implementation - #1585

Merged
Alexander Sehr (AlexanderSehr) merged 12 commits into
mainfrom
users/alsehr/780_dfEndpointsAndCMK
Jul 4, 2022
Merged

[Modules] DataFactory: Added private endpoints & customer-managed-key implementation#1585
Alexander Sehr (AlexanderSehr) merged 12 commits into
mainfrom
users/alsehr/780_dfEndpointsAndCMK

Conversation

@AlexanderSehr

@AlexanderSehr Alexander Sehr (AlexanderSehr) commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

Description

  • Added private endpoint parameter & cross-reference
  • Added CMK implementation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DataFactory: Factories

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr Alexander Sehr (AlexanderSehr) linked an issue Jun 24, 2022 that may be closed by this pull request
Set default values to a secure value - Data Factory #780
Closed
@github-actions

github-actions Bot commented Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

116 tests   111 ✔️  27s ⏱️
    1 suites      5 💤
    1 files        0 ❌

Results for commit bc3c8a5.

♻️ This comment has been updated with latest results.

@AlexanderSehr Alexander Sehr (AlexanderSehr) added enhancement New feature or request [cat] modules category: modules labels Jun 24, 2022
@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as draft June 24, 2022 22:11
auto-merge was automatically disabled June 24, 2022 22:11

Pull request was converted to draft

@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as ready for review June 24, 2022 22:20
@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as draft June 27, 2022 15:50
@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as ready for review June 27, 2022 17:27
Closed
@AlexanderSehr
Alexander Sehr (AlexanderSehr) requested a review from a team as a code owner June 30, 2022 06:06
eriqua
Erika Gressi (eriqua) reviewed Jul 4, 2022
View reviewed changes
Comment thread modules/Microsoft.DataFactory/factories/deploy.bicep
eriqua
Erika Gressi (eriqua) reviewed Jul 4, 2022
View reviewed changes
Comment thread modules/Microsoft.DataFactory/factories/deploy.bicep Outdated
eriqua
Erika Gressi (eriqua) reviewed Jul 4, 2022
View reviewed changes
Comment thread modules/Microsoft.DataFactory/factories/.test/parameters.json
eriqua
Erika Gressi (eriqua) reviewed Jul 4, 2022
View reviewed changes
Comment thread modules/Microsoft.DataFactory/factories/deploy.bicep
eriqua
Erika Gressi (eriqua) reviewed Jul 4, 2022
View reviewed changes
Comment thread modules/Microsoft.DataFactory/factories/deploy.bicep
eriqua
Erika Gressi (eriqua) reviewed Jul 4, 2022
View reviewed changes
Comment thread modules/Microsoft.DataFactory/factories/.test/parameters.json
eriqua
Erika Gressi (eriqua) approved these changes Jul 4, 2022
View reviewed changes

@eriqua Erika Gressi (eriqua) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr
Alexander Sehr (AlexanderSehr) deleted the users/alsehr/780_dfEndpointsAndCMK branch July 4, 2022 13:37
@eriqua Erika Gressi (eriqua) linked an issue Jul 8, 2022 that may be closed by this pull request
[Feature Request]: Customer Managed Key support for Azure Data Factory #1538
Closed
@eriqua Erika Gressi (eriqua) mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua Erika Gressi (eriqua) eriqua approved these changes

Assignees

@AlexanderSehr Alexander Sehr (AlexanderSehr)

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Customer Managed Key support for Azure Data Factory Set default values to a secure value - Data Factory

2 participants

@AlexanderSehr @eriqua