Skip to content

[CI Environment] Enabled CI environment to handle DeploymentTest (bicep) files for new self-contained dependency approach - #1624

Merged
Alexander Sehr (AlexanderSehr) merged 308 commits into
mainfrom
users/alsehr/1583_dependencyVar5
Aug 29, 2022
Merged

Alexander Sehr (AlexanderSehr) merged 308 commits into
mainfrom
users/alsehr/1583_dependencyVar5

Conversation

@AlexanderSehr

@AlexanderSehr Alexander Sehr (AlexanderSehr) commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Description

Implementing 'Self-contained' module dependency deployment for variant 5 #329

Tasks

  • Adjust GitHub workflows
  • Adjust Azure DevOps pipelines
  • Update Set-ModuleReadMe function to be able to convert bicep to JSON parameter
  • Test GitHub (with and without new type of dependency file)
  • Test ADO (with and without new type of dependency file)
  • Test pure ARM execution & utilities
  • Test Azure DevOps dependency pipeline
  • Test GitHub dependency pipeline
  • Update docs

Open questions

  • Should Set-ModuleReadMe script support ARM-JSON-Module-Test files and extract 'parameters'?
GitHub

image

Azure DevOps

image

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

GitHub Workflow Azure DevOps Pipeline New test files
Sql: Servers Build Status
AnalysisServices: Servers Build Status
Network: VPN Sites Build Status
Compute: VirtualMachines Build Status
KeyVault: Vaults Build Status 📎 (no)
.Platform: Dependencies (unrelated) Build Status
ARM Test AnalysisServices: Servers Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@github-actions

github-actions Bot commented Jun 29, 2022

Copy link
Copy Markdown

Unit Test Results

    1 files  ±    0      1 suites  ±0   1m 29s ⏱️ - 2m 22s
204 tests  - 370  200 ✔️  - 365  4 💤  - 5  0 ±0 
214 runs   - 362  209 ✔️  - 358  5 💤  - 4  0 ±0 

Results for commit de97a2f. ± Comparison against base commit 7c0e98d.

♻️ This comment has been updated with latest results.

Ensured that key vault is removed before resource group to ensure purge
Added KeyVault purge for purge protected key vaults

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and suggestions.

Comment thread .azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml Outdated
Comment thread .azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml Outdated
Comment thread .azuredevops/pipelineTemplates/jobs.validateModuleDeployment.yml Outdated
Comment thread .github/actions/templates/validateModuleDeployment/action.yml Outdated
Comment thread .github/actions/templates/validateModuleDeployment/action.yml Outdated
Comment thread modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep Outdated
Comment thread modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep Outdated
Comment thread modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep Outdated
Comment thread modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep Outdated
Comment thread modules/.shared/dependencyConstructs/diagnostic.dependencies.bicep Outdated
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
…icep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Comment thread docs/wiki/The library - Module design.md Outdated
@AlexanderSehr
Alexander Sehr (AlexanderSehr) deleted the users/alsehr/1583_dependencyVar5 branch August 29, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines [cat] testing category: testing [prio] high importance of the issue: high priority

Projects

None yet

2 participants