[Modules] Updated Authorization/policyDefinitions to new dependency approach - #1813
Merged
Alexander Sehr (AlexanderSehr) merged 12 commits intoOct 24, 2022
Conversation
Alexander Sehr (AlexanderSehr)
marked this pull request as ready for review
September 19, 2022 19:01
Alexander Sehr (AlexanderSehr)
requested a review
from a team
as a code owner
September 19, 2022 19:01
Alexander Sehr (AlexanderSehr)
enabled auto-merge (squash)
September 19, 2022 19:01
Ahmad Abdalla (ahmadabdalla)
self-requested a review
October 11, 2022 09:34
Contributor
|
Pending change to the implementation approach: |
Contributor
Author
As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able to properly handle this alternative approach. A larger refactoring may be required. |
Ahmad Abdalla (ahmadabdalla)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Alex. Minor suggestion on the serviceShort name, and please change the folder name to .common for MG and SUB.
Alexander Sehr (AlexanderSehr)
requested a review
from Ahmad Abdalla (ahmadabdalla)
October 24, 2022 07:38
Ahmad Abdalla (ahmadabdalla)
approved these changes
Oct 24, 2022
Alexander Sehr (AlexanderSehr)
deleted the
users/alsehr/1791_Authorization_PolicyDefinitions
branch
October 24, 2022 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pipeline references
Type of Change
Please delete options that are not relevant.