Skip to content

[Modules] Updated NSG to new dependency approach - #1886

Merged
Alexander Sehr (AlexanderSehr) merged 8 commits into
mainfrom
users/alsehr/1791_Network_networkSecurityGroups
Oct 13, 2022
Merged

[Modules] Updated NSG to new dependency approach#1886
Alexander Sehr (AlexanderSehr) merged 8 commits into
mainfrom
users/alsehr/1791_Network_networkSecurityGroups

Conversation

@AlexanderSehr

@AlexanderSehr Alexander Sehr (AlexanderSehr) commented Sep 4, 2022

Copy link
Copy Markdown
Contributor

Description

  • Updated NSG to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: NetworkSecurityGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr Alexander Sehr (AlexanderSehr) added [cat] modules category: modules [cat] testing category: testing labels Sep 4, 2022
@AlexanderSehr Alexander Sehr (AlexanderSehr) mentioned this pull request Sep 4, 2022
Closed
@github-actions

github-actions Bot commented Sep 4, 2022

Copy link
Copy Markdown

Unit Test Results

  1 files    1 suites   43s ⏱️
90 tests 88 ✔️ 2 💤 0 ❌
97 runs  94 ✔️ 3 💤 0 ❌

Results for commit beecd13.

@AlexanderSehr Alexander Sehr (AlexanderSehr) linked an issue Sep 5, 2022 that may be closed by this pull request
Update Network/networkSecurityGroups to new dependencies approach #1951
Closed
@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as ready for review September 19, 2022 06:08
@AlexanderSehr
Alexander Sehr (AlexanderSehr) deleted the users/alsehr/1791_Network_networkSecurityGroups branch October 13, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MariusStorhaug Marius Storhaug (MariusStorhaug) Awaiting requested review from MariusStorhaug
1 more reviewer
@ahmadabdalla Ahmad Abdalla (ahmadabdalla) ahmadabdalla approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AlexanderSehr Alexander Sehr (AlexanderSehr)

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Network/networkSecurityGroups to new dependencies approach

2 participants

@AlexanderSehr @ahmadabdalla