Skip to content

[Modules] Update Network LoadBalancer to new dependency approach - #2040

Merged
Alexander Sehr (AlexanderSehr) merged 7 commits into
mainfrom
users/alsehr/1791_Network_loadBalancers
Oct 11, 2022
Merged

[Modules] Update Network LoadBalancer to new dependency approach#2040
Alexander Sehr (AlexanderSehr) merged 7 commits into
mainfrom
users/alsehr/1791_Network_loadBalancers

Conversation

@AlexanderSehr

@AlexanderSehr Alexander Sehr (AlexanderSehr) commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Description

  • Update Network LoadBalancer to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: LoadBalancers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr Alexander Sehr (AlexanderSehr) added [cat] modules category: modules [cat] testing category: testing labels Sep 16, 2022
@AlexanderSehr Alexander Sehr (AlexanderSehr) linked an issue Sep 16, 2022 that may be closed by this pull request
Update Network/loadBalancers to new dependencies approach #2039
Closed
@github-actions

github-actions Bot commented Sep 16, 2022 •
edited
Loading

Copy link
Copy Markdown

Unit Test Results

    1 files      1 suites   1m 8s ⏱️
127 tests 124 ✔️ 3 💤 0 ❌
147 runs  142 ✔️ 5 💤 0 ❌

Results for commit 489f858.

♻️ This comment has been updated with latest results.

AlexanderSehr
Alexander Sehr (AlexanderSehr) commented Sep 18, 2022
View reviewed changes
Comment thread modules/Microsoft.Network/loadBalancers/.test/min/deploy.test.bicep Outdated
@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as ready for review September 18, 2022 22:09
eriqua
Erika Gressi (eriqua) approved these changes Oct 11, 2022
View reviewed changes

@eriqua Erika Gressi (eriqua) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr
Alexander Sehr (AlexanderSehr) deleted the users/alsehr/1791_Network_loadBalancers branch October 11, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua Erika Gressi (eriqua) eriqua approved these changes

Assignees

@AlexanderSehr Alexander Sehr (AlexanderSehr)

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Network/loadBalancers to new dependencies approach

2 participants

@AlexanderSehr @eriqua