Skip to content

[Modules] Updated HealthBots to new dependencies approach - #2098

Merged
Alexander Sehr (AlexanderSehr) merged 3 commits into
mainfrom
users/alsehr/1791_HealthBot_healthBots
Oct 6, 2022
Merged

[Modules] Updated HealthBots to new dependencies approach#2098
Alexander Sehr (AlexanderSehr) merged 3 commits into
mainfrom
users/alsehr/1791_HealthBot_healthBots

Conversation

@AlexanderSehr

@AlexanderSehr Alexander Sehr (AlexanderSehr) commented Sep 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Updated HealthBots to new dependencies approach
  • Updated test script to deal better with empty lines (as readme script introduced new empty lines)

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
HealthBot: HealthBots

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr Alexander Sehr (AlexanderSehr) added [cat] modules category: modules [cat] testing category: testing labels Sep 21, 2022
@AlexanderSehr Alexander Sehr (AlexanderSehr) linked an issue Sep 21, 2022 that may be closed by this pull request
Update HealthBot/healthBots to new dependencies approach #2097
Closed
@github-actions

github-actions Bot commented Sep 21, 2022

Copy link
Copy Markdown

Unit Test Results

  1 files    1 suites   31s ⏱️
52 tests 50 ✔️ 2 💤 0 ❌
59 runs  56 ✔️ 3 💤 0 ❌

Results for commit 3411b81.

@AlexanderSehr Alexander Sehr (AlexanderSehr) changed the title [Modules ]Updated HealthBots to new dependencies approach & readme script update [Modules ]Updated HealthBots to new dependencies approach & increased test robustness Sep 21, 2022
@eriqua Erika Gressi (eriqua) changed the title [Modules ]Updated HealthBots to new dependencies approach & increased test robustness [Modules ]Updated HealthBots to new dependencies approach Oct 5, 2022
@eriqua Erika Gressi (eriqua) changed the title [Modules ]Updated HealthBots to new dependencies approach [Modules ] Updated HealthBots to new dependencies approach Oct 5, 2022
eriqua
Erika Gressi (eriqua) approved these changes Oct 6, 2022
View reviewed changes

@eriqua Erika Gressi (eriqua) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr
Alexander Sehr (AlexanderSehr) deleted the users/alsehr/1791_HealthBot_healthBots branch October 6, 2022 09:03
@eriqua Erika Gressi (eriqua) changed the title [Modules ] Updated HealthBots to new dependencies approach [Modules] Updated HealthBots to new dependencies approach Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua Erika Gressi (eriqua) eriqua approved these changes

Assignees

@AlexanderSehr Alexander Sehr (AlexanderSehr)

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update HealthBot/healthBots to new dependencies approach

2 participants

@AlexanderSehr @eriqua