Adjusted implementation for testing - #2251
Merged
Fabio Masciotra (fabmas) merged 1 commit intoOct 25, 2022
Merged
Fabio Masciotra (fabmas) merged 1 commit into
Fabio Masciotra (fabmas) merged 1 commit into
Conversation
Alexander Sehr (AlexanderSehr)
requested a review
from a team
as a code owner
October 25, 2022 13:48
Alexander Sehr (AlexanderSehr)
requested review from
Erika Gressi (eriqua) and
Fabio Masciotra (fabmas)
October 25, 2022 13:49
7 tasks
Contributor
There was a problem hiding this comment.
@MrMCake, Fabio Masciotra (@fabmas) I guess the advantage of this approach is one module less and thus one Azure deployment less. Other modules using dependencies_rbac.bicep (e.g. compute images) are in fact forced to call dependencies_rbac.bicep from dependencies.bicep because that assignment is needed in turns by other dependencies, while in this case it's needed by the main resource. This approach is cleaner, so if Fabio Masciotra (@fabmas) agrees I'd vote for it.
Fabio Masciotra (fabmas)
deleted the
users/fabmas/2226_vmimages_alsehrTest
branch
October 25, 2022 16:35
Fabio Masciotra (fabmas)
added a commit
that referenced
this pull request
Oct 26, 2022
…ies approach (#2250) * new dependency VMImage * Update dependencies.bicep * contibutor * readme * RBAC * reourceGroup * subscriptions * Adjusted implementation for testing (#2251) * Update modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com> * Update modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com> * Update modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com> Co-authored-by: Fabio Masciotra <fabmas@microsoft.com> Co-authored-by: elisa anzelmo <elisa.anzelmo@microsoft.com> Co-authored-by: Alexander Sehr <ASehr@hotmail.de> Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pipeline references