Skip to content

[Fixes] Update remaining API for networking resources - #3780

Merged
Ahmad Abdalla (ahmadabdalla) merged 8 commits into
Azure:users/alsehr/devApiAndDiagfrom
MariusStorhaug:fix/API
Aug 27, 2023
Merged

Ahmad Abdalla (ahmadabdalla) merged 8 commits into
Azure:users/alsehr/devApiAndDiagfrom
MariusStorhaug:fix/API

Conversation

@MariusStorhaug

@MariusStorhaug Marius Storhaug (MariusStorhaug) commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

Description

  • vpn-gateway/nat-rule (2022-07-01) -> (2023-04-01)
  • vpn-gateway/vpn-connection (2022-07-01) -> (2023-04-01)
    • New parameter: dpdTimeoutSeconds
  • virtual-network-gateway/nat-rule (2022-07-01) -> (2023-04-01)
  • virtual-network/subnet (2022-07-01) -> (2023-04-01)
    • New API, new casing:
      image
    • Update subnet reference in constructs
  • network-security-group/security-rule (2022-07-01) -> (2023-04-01)
  • load-balancer/backend-address-pool (2022-07-01) -> (2023-04-01)
    • New parameter: syncMode
  • load-balancer/inbound-nat-rule (2022-07-01) -> (2023-04-01)
    • tests updated that were deploying load-balancer/inbound-nat-rule
      • network/network-interface
  • firewall-policy/rule-collection-group (2022-07-01) -> (2023-04-01)

Pipeline references

Pipeline

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug

Copy link
Copy Markdown
Contributor Author

Just doing a full regen of ARM/json and readme to be sure i didn't miss anything.

@MariusStorhaug
Marius Storhaug (MariusStorhaug) marked this pull request as ready for review August 27, 2023 23:25
@MariusStorhaug

Marius Storhaug (MariusStorhaug) commented Aug 27, 2023

Copy link
Copy Markdown
Contributor Author

Ahmad Abdalla (@ahmadabdalla) Should be all good now. I will run the pipelines w/o validation deployments again just to check. Feel free to merge if you don't need to wait for that, as it would be just as fine running in Azure/ResourceModules repo.

@ahmadabdalla
Ahmad Abdalla (ahmadabdalla) merged commit 02f42b6 into Azure:users/alsehr/devApiAndDiag Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [prio] high importance of the issue: high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants