Create ADO pipelines for validate, deploy, remove & publish - #476
Merged
Merged
Conversation
Alexander Sehr (AlexanderSehr)
marked this pull request as draft
November 17, 2021 11:29
Alexander Sehr (AlexanderSehr)
requested a review
from Ahmad Abdalla (ahmadabdalla)
December 12, 2021 10:18
Contributor
|
I am in the progress of reviewing. Its just a big PR... |
Marius Storhaug (MariusStorhaug)
self-requested a review
December 12, 2021 23:09
Contributor
|
Based on the file name change, should we not replace the following: |
Marius Storhaug (MariusStorhaug)
suggested changes
Dec 13, 2021
Contributor
|
Need to have a look at how we allow the action to also work with ARM/json template files. |
Contributor
|
What about child resources? They are not nested templates when converted to json. Should we also remove/clean up the folders representing the child resources? |
Alexander Sehr (AlexanderSehr)
enabled auto-merge (squash)
December 13, 2021 16:29
Alexander Sehr (AlexanderSehr)
requested a review
from Marius Storhaug (MariusStorhaug)
December 13, 2021 16:29
Marius Storhaug (MariusStorhaug)
approved these changes
Dec 13, 2021
Marius Storhaug (MariusStorhaug)
left a comment
Contributor
There was a problem hiding this comment.
All of my comments are fixed. Approved.
Alexander Sehr (AlexanderSehr)
dismissed
Ahmad Abdalla (ahmadabdalla)’s stale review
December 13, 2021 16:37
Marius did just that ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Created Azure DevOps pipelines for validate, deploy, remove & publish
Renamed GitHub variables file to
global.variables.jsonto align with the Azure DevOps variable file (which has a better name -global.variables.yml)Overhauled documentation
Tested:
Out of scope
Notes:
Pipeline reference
See IaCS Pipelines in folder 'CARML-Modules'
Type of Change
Please delete options that are not relevant.
Checklist