support swagger resource provider with multiple readme files - #440
Merged
kai ru (kairu-ms) merged 2 commits intoDec 27, 2024
Merged
Conversation
kai ru (kairu-ms)
requested review from
AllyW,
Copilot and
Ethan Yang (necusjz)
December 27, 2024 03:03
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/aaz_dev/swagger/model/specs/_resource_provider.py:19
- [nitpick] The variable name
readme_pathscould be more descriptive. Consider renaming it toreadme_file_paths.
def __init__(self, name, folder_path, readme_paths, swagger_module):
src/aaz_dev/swagger/model/specs/_resource_provider.py:110
- The error message could be more descriptive by including the specific readme file path that caused the error.
logger.error(f'ParseYamlFailed: {self} : {readme_path} {flags}: {err}')
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AllyW
approved these changes
Dec 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.