Skip to content

fix dependence issue - #352

Closed
kai ru (kairu-ms) wants to merge 1 commit into
Azure:devfrom
kairu-ms:fix-dependencies
Closed

kai ru (kairu-ms) wants to merge 1 commit into
Azure:devfrom
kairu-ms:fix-dependencies

Conversation

@kairu-ms

@kairu-ms kai ru (kairu-ms) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

tox>=4 required on packaging>=23, which conflicts with azure-cli

@jiasli

Jiashuo Li (jiasli) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

From security perspective, we should always use latest versions of libraries, or we will have potential security risks.

We should bump Azure CLI's dependency on packaging instead: https://github.com/Azure/azure-cli/blob/ce12ce99cf78b9e43ca10270577e383cff9dd0a6/src/azure-cli-core/setup.py#L56

Comment thread setup.py
'requests',
'sphinx==1.6.7',
'tox',
'tox~=3.28.0',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we have bumped packaging (Azure/azure-cli#25371), do we still need to pin Jinja2?

@wangzelin007

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants