(aks-preview): Fix omitted FlexNodes node taints - #10351
Merged
Ethan Yang (necusjz) merged 3 commits intoSep 18, 2026
Merged
Ethan Yang (necusjz) merged 3 commits into
Ethan Yang (necusjz) merged 3 commits into
Conversation
Karen Chen (karenychen)
requested a review
from FumingZhang
as a code owner
September 16, 2026 18:47
|
Hi Karen Chen (@karenychen), |
microsoft-github-policy-service
Bot
requested review from
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 16, 2026 18:47
Copilot started reviewing on behalf of
Karen Chen (karenychen)
September 16, 2026 18:48
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified.
Pull request overview
Fixes FlexNodes node-taint handling during node pool creation.
Changes:
- Omits unspecified taints.
- Rejects explicitly empty taint values.
- Adds regression tests and a Pending changelog entry.
File summaries
| File | Description |
|---|---|
src/aks-preview/HISTORY.rst |
Documents the fix. |
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py |
Adds FlexNodes taint behavior tests. |
src/aks-preview/azext_aks_preview/agentpool_decorator.py |
Implements taint handling. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hbc (bcho)
approved these changes
Sep 16, 2026
Karen Chen (karenychen)
deleted the
codex/flexnodes-node-taints-omission
branch
September 16, 2026 22:29
Collaborator
|
aks-preview |
Karen Chen (karenychen)
restored the
codex/flexnodes-node-taints-omission
branch
September 17, 2026 17:41
Contributor
Author
|
local test: |
hbc (bcho)
approved these changes
Sep 17, 2026
FumingZhang
approved these changes
Sep 18, 2026
Collaborator
|
[Release] Update index.json for extension [ aks-preview-22.0.0b8 ] : https://dev.azure.com/msazure/One/_build/results?buildId=181672988&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az aks nodepool add --vm-set-type FlexNodesSummary
--node-taintsvalue for FlexNodes node pool creation so the SDK omitsnodeTaints--node-taintsvalue for FlexNodesaks-previewversion22.0.0b8through matchingsetup.pyandHISTORY.rstupdatesTesting
python -m pytest -q src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py— 137 passedazdev style aks-preview— Pylint passed; Flake8 passedpython scripts/ci/test_index.py -q— 9 tests passed (2 skipped)python setup.py --version—22.0.0b8General Guidelines
azdev style <YOUR_EXT>locally?python scripts/ci/test_index.py -qlocally?22.0.0b8.