[AKS] aks create/update: add --vnet-subnet_id validationChenyzh vnet validator

[CHENYI ZHANG (Czhang0727)]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

[Azure Builder (azuresdkci)]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Czhang0727/azure-cli-extensions.git@chenyzh_vnetValidator#subdirectory=src/$EXT&egg=$EXT"

[CHENYI ZHANG (Czhang0727)]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Czhang0727/azure-cli-extensions.git@chenyzh_vnetValidator#subdirectory=src/$EXT&egg=$EXT"

Tested in docker, expected result received.

bash-5.0# az aks create -g chenyzh --vnet-subnet-id dumy -n cztest --ssh-key-value .ssh/id_rsa.pub 
The behavior of this command has been altered by the following extension: aks-preview
--vnet-subnet-id is not a valid Azure resource ID.

bash-5.0# az aks create -g chenyzh --vnet-subnet-id /subscriptions/YourSubscriptionId/resourceGroups/YourResourceGroupName/providers/Microsoft.Network/virtualNetworks/Name -n cztest --ssh-key-value ~/.ssh/id_rsa.pub
The behavior of this command has been altered by the following extension: aks-preview
Resource group 'chenyzh' could not be found.

bash-5.0# az aks create -g chenyzh --vnet-subnet-id "" -n cztest --ssh-key-value ~/.ssh/id_rsa.pub
The behavior of this command has been altered by the following extension: aks-preview
Resource group 'chenyzh' could not be found.

[Azure Builder (azuresdkci)]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Czhang0727/azure-cli-extensions.git@chenyzh_vnetValidator#subdirectory=src/$EXT&egg=$EXT"

[CHENYI ZHANG (Czhang0727)]

Did not realize "close and comment" will actually close entire PR while Azure DevOps just close the comment, re-open for continuing the review.

[CHENYI ZHANG (Czhang0727)]

Re-try validation as one of check is expire

[Azure Builder (azuresdkci)]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Czhang0727/azure-cli-extensions.git@chenyzh_vnetValidator#subdirectory=src/$EXT&egg=$EXT"

[Yong Zhang (yonzhan)]

add to S165.

[Yong Zhang (yonzhan)]

add to S165.

[Myron (mmyyrroonn)]

CHENYI ZHANG (@Czhang0727) Hello. I remembered that I merged a same PR. Is that in CLI main repo?

[Myron (mmyyrroonn)]

LGTM. Feiyue Yu (@qwordy) please leave your comments and sign off

[CHENYI ZHANG (Czhang0727)]

CHENYI ZHANG (@Czhang0727) Hello. I remembered that I merged the same PR. Is that in CLI main repo?

myronfanqiu Hi, I already checked in the same update in azure-cli as recommended. The update is already checked in.
Azure/azure-cli#12038

I added a little bouns as I saw there is a styling warning with an un-necessary return.

[CHENYI ZHANG (Czhang0727)]

Feiyue Yu (@qwordy), any chance we can merge the change?

[Feiyue Yu (qwordy)]

Does it has a help message?

[CHENYI ZHANG (Czhang0727)]

yes it does, it keeps same as it was to be in _help.py

        - name: --vnet-subnet-id
          type: string
          short-summary: The ID of a subnet in an existing VNet into which to deploy the cluster.

[CHENYI ZHANG (Czhang0727)]

merge conflict for check-in

[CHENYI ZHANG (Czhang0727)]

Feiyue Yu (@qwordy) Hi, would it possible to have the file merged and checked in?
I found this PR is stuck here for too long, and new PRs are keep conflicts the fixing there.

[Feiyue Yu (qwordy)]

We are very sorry to leave this PR unmerged for a long time. Can you resolve the conflicts again?

[CHENYI ZHANG (Czhang0727)]

Feiyue Yu (@qwordy) Resolved conflict and verified through the pipeline.
Let me know if there is still any blocker for check in