Skip to content

Add "Did You Mean This" Extension - #1536

Closed
Christopher O'Toole (christopher-o-toole) wants to merge 0 commit into
Azure:masterfrom
christopher-o-toole:thoth-extension
Closed

Christopher O'Toole (christopher-o-toole) wants to merge 0 commit into
Azure:masterfrom
christopher-o-toole:thoth-extension

Conversation

@christopher-o-toole

@christopher-o-toole Christopher O'Toole (christopher-o-toole) commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

New extension (in preview) which uses the Aladdin service to generate and show failure recovery recommendations on command failure. This extension makes use of the hook added to parser.py in CLI version 2.4.0. For more information, see this CLI PR.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@yonzhan

Copy link
Copy Markdown
Collaborator

ai

Comment thread src/ai-did-you-mean-this/setup.cfg Outdated
Comment on lines 11 to 15

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe combine them?

Suggested change
with self.command_group('ai-did-you-mean-this') as g:
g.custom_command('version', 'show_extension_version')
with self.command_group('ai-did-you-mean-this', is_preview=True):
pass
with self.command_group('ai-did-you-mean-this', is_preview=True) as g:
g.custom_command('version', 'show_extension_version')

Comment thread src/ai-did-you-mean-this/README.rst Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding some instructions and usage scenarios? Like what kind of error can trigger this extension.

Comment on lines 20 to 26

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also honor the no_color setting: Azure/azure-cli#12601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants