[AKS] add ephemeral os functionality

[Ace Eldeib (alexeldeib)]

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

[Azure Builder (azuresdkci)]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/alexeldeib/azure-cli-extensions.git@ace/ephemeral#subdirectory=src/$EXT&egg=$EXT"

[Ace Eldeib (alexeldeib)]

Marwan Ahmed (@marwanad)

[Marwan Ahmed (marwanad)]

reason for change?

[Ace Eldeib (alexeldeib)]

I got lint errors on this running python linters as specified by CLI. (len-as-condition, pylint C1801)

seems like that's a bit debatable as far as being preferable itself, though: pylint-dev/pylint#1405 (comment)

[Marwan Ahmed (marwanad)]

surprised CI didn't catch that

[Yunge Zhu (yungezz)]

is this required? or optional? if optional pls set it to None

[Ace Eldeib (alexeldeib)]

optional, will do

[Xiaojian Xu (arrownj)]

Since arg_type=get_enum_type([CONST_OS_DISK_TYPE_MANAGED, CONST_OS_DISK_TYPE_EPHEMERAL]) is used in _param.py, the framework will automatically add "Allowed values" list for it. We do not need to add manually here.

And if the default value is "Managed", we can directly define the custom function as below:

def aks_create(cmd, # pylint: disable=too-many-locals,too-many-statements,too-many-branches
client, client,
resource_group_name, resource_group_name,
name, name,
ssh_key_value, ssh_key_value,
dns_name_prefix=None, dns_name_prefix=None,
location=None, location=None,
admin_username="azureuser", admin_username="azureuser",
windows_admin_username=None, windows_admin_username=None,
windows_admin_password=None, windows_admin_password=None,
kubernetes_version='', kubernetes_version='',
node_vm_size="Standard_DS2_v2", node_vm_size="Standard_DS2_v2",
node_osdisk_type="Managed",

The framework will also add Default value in help message automatically.

[Ace Eldeib (alexeldeib)]

I'll remove it from the help 👍 but I don't think we want to default this value client side, we want it to be empty and we will default it server side.

In October, the defaulting behavior on server side will get slightly more complex when the value isn't provided and I would strongly prefer not to copy that defaulting behavior into the client.

[Azure Builder (azuresdkci)]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/alexeldeib/azure-cli-extensions.git@ace/ephemeral#subdirectory=src/$EXT&egg=$EXT"

[Ace Eldeib (alexeldeib)]

had to re-run appgw tests to get fresh recording to pass (think this is related to recent issues with normalization in the names), sorry about that

[Xiaojian Xu (arrownj)]

The code is good to me.