Fix 'az webapp config ssl bind' for web apps in kubernetes environments - #4129
Conversation
|
webapp |
ZelinWang (wangzelin007)
left a comment
There was a problem hiding this comment.
Please update setup.py to release the new extension version.
And may I ask you to add some scenario tests for those new commands?
|
Silas Strawn (@StrawnSC) is this PR ready for review & if so can we get this released on the extension soon. Thanks! |
|
Sisira Panchagnula (@panchagnula) sorry for the hold up -- I was taking some time to test and make sure that certificate binding was working for lima web apps and lima web app slots. I'm marking the PR ready for review ZelinWang (@wangzelin007) thanks, I just updated the |
Sisira Panchagnula (panchagnula)
left a comment
There was a problem hiding this comment.
LGTM
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.