Skip to content

Fix 'az webapp config ssl bind' for web apps in kubernetes environments - #4129

Merged
Sisira Panchagnula (panchagnula) merged 5 commits into
Azure:mainfrom
StrawnSC:fix_ssl_bind_for_lima
Dec 2, 2021
Merged

Sisira Panchagnula (panchagnula) merged 5 commits into
Azure:mainfrom
StrawnSC:fix_ssl_bind_for_lima

Conversation

@StrawnSC

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan

Copy link
Copy Markdown
Collaborator

webapp

@wangzelin007 ZelinWang (wangzelin007) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update setup.py to release the new extension version.
And may I ask you to add some scenario tests for those new commands?

@panchagnula

Copy link
Copy Markdown
Contributor

Silas Strawn (@StrawnSC) is this PR ready for review & if so can we get this released on the extension soon. Thanks!

@StrawnSC

Copy link
Copy Markdown
Contributor Author

Sisira Panchagnula (@panchagnula) sorry for the hold up -- I was taking some time to test and make sure that certificate binding was working for lima web apps and lima web app slots. I'm marking the PR ready for review

ZelinWang (@wangzelin007) thanks, I just updated the setup.py. About scenario tests, as we mentioned here, the process of setting up an AKS cluster to put kubernetes environments in is quite lengthy/time-consuming and doesn't lend itself well to automated testing. So far, we've been manually testing the commands. We're planning on finding a way to add scenario tests before integrating this into the core CLI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panchagnula
Sisira Panchagnula (panchagnula) merged commit 192c045 into Azure:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants