[AKS] support blob csi driver - #5027
Merged
Xing Zhou (zhoxing-ms) merged 13 commits intoJun 23, 2022
Merged
Xing Zhou (zhoxing-ms) merged 13 commits into
Xing Zhou (zhoxing-ms) merged 13 commits into
Conversation
weizhi (cvvz)
requested review from
FumingZhang and
Liming Liu (andyliuliming)
as code owners
June 22, 2022 04:48
Collaborator
|
AKS |
Yong Zhang (yonzhan)
requested review from
ZelinWang (wangzelin007) and
Xing Zhou (zhoxing-ms)
June 22, 2022 06:21
Contributor
…into aks-preview-support-blob-csi-driver
…into aks-preview-support-blob-csi-driver
|
|
||
| if self.decorator_mode == DecoratorMode.UPDATE: | ||
| if enable_blob_driver: | ||
| msg = "Please make sure there is no open-source Blob CSI driver installed before enabling." |
Contributor
There was a problem hiding this comment.
Meagan (@olsenme) could you review the msg syntax? thanks.
Andy Zhang (andyzhangx)
approved these changes
Jun 23, 2022
Xing Zhou (zhoxing-ms)
approved these changes
Jun 23, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.