{AKS} Fix #23468: az aks nodepool wait crashes with error "'Namespace' object has no attribute 'nodepool_name'" - #5219
Merged
Xing Zhou (zhoxing-ms) merged 3 commits intoAug 10, 2022
Conversation
ghost
requested review from
ZelinWang (wangzelin007) and
Xing Zhou (zhoxing-ms)
August 9, 2022 10:55
ghost
requested a review
from Yong Zhang (yonzhan)
August 9, 2022 10:56
Collaborator
|
AKS |
FumingZhang
force-pushed
the
fuming/fix-aks-nodepool-wait-0809
branch
from
August 10, 2022 02:39
b38215d to
f61703c
Compare
FumingZhang
marked this pull request as ready for review
August 10, 2022 03:01
FumingZhang
requested a review
from Liming Liu (andyliuliming)
as a code owner
August 10, 2022 03:01
az aks nodepool wait: Fix for "'Namespace' object has no attribute 'nodepool_name' error"az aks nodepool wait crashes with error "'Namespace' object has no attribute 'nodepool_name'"
3 tasks
Xing Zhou (zhoxing-ms)
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
The implementation of the
az aks nodepool waitcommand directly calls the operation provided by the SDK, and the parameter name used to identify the nodepool name isagent_pool_name, which is different from the parameter namenodepool_namein the custom implemented nodepool commands.The fix is to add a new dedicated validator for the command. Also added some unit tests. See sibling PR #23489.
Fix issue #23468.
Related command
az aks nodepool waitGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.