[Work In Progress - Do Not Merge] Connectedk8s: Add "arc "mode in Guard for using OBO service - #6590
Closed
Vineeth Thumma (vineeth-thumma) wants to merge 0 commit into
Closed
Vineeth Thumma (vineeth-thumma) wants to merge 0 commit into
Vineeth Thumma (vineeth-thumma) wants to merge 0 commit into
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi Vineeth Thumma (@vineeth-thumma), |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Yong Zhang (yonzhan)
requested review from
Julie Zhu (yanzhudd) and
Xing Zhou (zhoxing-ms)
August 3, 2023 00:53
Vineeth Thumma (vineeth-thumma)
marked this pull request as ready for review
August 3, 2023 20:04
Julien Stroheker (julienstroheker)
suggested changes
Aug 7, 2023
Julien Stroheker (julienstroheker)
left a comment
There was a problem hiding this comment.
Blocking PR for now. Since we want to wait before this getting merged.
Vineeth Thumma (vineeth-thumma)
force-pushed
the
main
branch
from
August 22, 2023 19:26
257e154 to
f28a5d7
Compare
Contributor
Author
|
Closed this in favor of #6675 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.