Skip to content

Stackhcivm 0.1.8 - #7017

Closed
wyatt-troia-msft wants to merge 1 commit into
Azure:mainfrom
wyatt-troia-msft:stackhcivm-0.1.8
Closed

wyatt-troia-msft wants to merge 1 commit into
Azure:mainfrom
wyatt-troia-msft:stackhcivm-0.1.8

Conversation

@wyatt-troia-msft

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
    • This command has never worked for us
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Nov 21, 2023

Copy link
Copy Markdown
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi wyatt-troia-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We will review the pull request and get back to you soon.

@cesquedamsft

Copy link
Copy Markdown
Member

Yong Zhang (@yonzhan) is there an ETA for the review?

@wyatt-troia-msft

Copy link
Copy Markdown
Contributor Author

Yong Zhang (@yonzhan) is there an ETA for the review?

kai ru (@kairu-ms) when can we expect a review?

@yonzhan

Copy link
Copy Markdown
Collaborator

Please fix the conflicting files

@wyatt-troia-msft

wyatt-troia-msft commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

Please fix the conflicting files

Yong Zhang (@yonzhan) Done. I had neglected to update my fork based on the upstream (this repo).

@wyatt-troia-msft

Copy link
Copy Markdown
Contributor Author

Yong Zhang (@yonzhan) I do not understand the CI failures. Can you please advise on how to clear them?

@kairu-ms

Copy link
Copy Markdown
Contributor

@kairu-ms

Copy link
Copy Markdown
Contributor

@wyatt-troia-msft

wyatt-troia-msft commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

BTW, the linter failed because of https://dev.azure.com/azclitools/public/_build/results?buildId=111708&view=logs&j=b121d099-c3c0-52ad-95f1-31c1567c9ad4&t=ca40adef-e63f-5fd5-f30e-e39a0bf0e914&l=358

I don't understand this error. I've compared the metadata for the new block I'm adding and the block for the last version of stack-hci-vm and they seem to be nearly identical. The error seems to be saying that the metadata for version 1.8 should say that its version is 1.5. Why would that be?

@kairu-ms

Copy link
Copy Markdown
Contributor

BTW, the linter failed because of https://dev.azure.com/azclitools/public/_build/results?buildId=111708&view=logs&j=b121d099-c3c0-52ad-95f1-31c1567c9ad4&t=ca40adef-e63f-5fd5-f30e-e39a0bf0e914&l=358

I don't understand this error. I've compared the metadata for the new block I'm adding and the block for the last version of stack-hci-vm and they seem to be nearly identical. The error seems to be saying that the metadata for version 1.8 should say that its version is 1.5. Why would that be?

Can you verify the whl package in the download link is version 1.8?

@ggaurav10

Copy link
Copy Markdown
Member

BTW, the linter failed because of https://dev.azure.com/azclitools/public/_build/results?buildId=111708&view=logs&j=b121d099-c3c0-52ad-95f1-31c1567c9ad4&t=ca40adef-e63f-5fd5-f30e-e39a0bf0e914&l=358

I don't understand this error. I've compared the metadata for the new block I'm adding and the block for the last version of stack-hci-vm and they seem to be nearly identical. The error seems to be saying that the metadata for version 1.8 should say that its version is 1.5. Why would that be?

Can you verify the whl package in the download link is version 1.8?

kai ru (@kairu-ms) from the pipeline error logs, I see that the metadata shows version as 0.1.5 whereas the changes in the PR has it as 0.1.8
image
image

I have also verified from the file that the metadata version is indeed 0.1.8

image

Is there a different place from where the pipeline is picking up the version?

@ggaurav10

Copy link
Copy Markdown
Member

wyatt-troia-msft Arka (@Arkanayan) do we need this kind of change before we build the whl file?
https://msazure.visualstudio.com/msk8s/_git/azstackhci-util/pullrequest/8265079

@Arkanayan

Copy link
Copy Markdown
Contributor

We can close this as these changes are merged in #7052

@wyatt-troia-msft
wyatt-troia-msft deleted the stackhcivm-0.1.8 branch November 30, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants